From: "Antoine Coeur" <Coeur@gmx.fr>
To: edk2-devel@lists.01.org
Subject: Re: [PATCH] CryptoPkg: Fix various typos
Date: Thu, 7 Feb 2019 18:05:01 +0100 [thread overview]
Message-ID: <trinity-152ceeca-a9e5-4712-87fc-4ab95c009101-1549559101539@3c-app-gmx-bs64> (raw)
In-Reply-To: <385afbeb-98a5-a15d-62ac-d720b4c72b51@redhat.com>
> My wonder is about what is the correct use between succeeds/succeeded,
> I'd expect the following diff:
>
> - @retval TRUE The time convertion succeeds.
> + @retval TRUE The time conversion succeeded.
In doubt, I'll just ignore this one. I made a v2 to address Jian review.
Thank you for reviewing this package.
Coeur
next prev parent reply other threads:[~2019-02-07 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 17:24 [PATCH] CryptoPkg: Fix various typos Antoine Coeur
2019-02-06 22:30 ` Philippe Mathieu-Daudé
2019-02-07 13:04 ` Ryszard Knop
2019-02-07 14:59 ` Philippe Mathieu-Daudé
2019-02-07 17:05 ` Antoine Coeur [this message]
2019-02-07 19:45 ` Laszlo Ersek
2019-02-07 6:25 ` Wang, Jian J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-152ceeca-a9e5-4712-87fc-4ab95c009101-1549559101539@3c-app-gmx-bs64 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox