From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Coeur@gmx.fr>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=212.227.17.22; helo=mout.gmx.net; envelope-from=coeur@gmx.fr;
 receiver=edk2-devel@lists.01.org 
Received: from mout.gmx.net (mout.gmx.net [212.227.17.22])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 0181D211CA2B6
 for <edk2-devel@lists.01.org>; Thu,  7 Feb 2019 09:05:03 -0800 (PST)
Received: from [47.52.140.127] ([47.52.140.127]) by web-mail.gmx.net
 (3c-app-gmx-bs64.server.lan [172.19.170.148]) (via HTTP); Thu, 7 Feb 2019
 18:05:01 +0100
MIME-Version: 1.0
Message-ID: <trinity-152ceeca-a9e5-4712-87fc-4ab95c009101-1549559101539@3c-app-gmx-bs64>
From: "Antoine Coeur" <Coeur@gmx.fr>
To: edk2-devel@lists.01.org
Date: Thu, 7 Feb 2019 18:05:01 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <385afbeb-98a5-a15d-62ac-d720b4c72b51@redhat.com>
References: <trinity-3257a839-64ee-491e-836d-e48eabfb4c44-1549473871002@3c-app-gmx-bs19>
 <280bb5d0-e01c-022e-6a02-6b744f61f28d@redhat.com>
 <2bf54b577aeef2a5529b3880d4d74e361f8a2089.camel@linux.intel.com>
 <385afbeb-98a5-a15d-62ac-d720b4c72b51@redhat.com>
X-UI-Message-Type: mail
X-Priority: 3
X-Provags-ID: V03:K1:txavczhlbdO6zG0o6eP1LL/jDelxUjyT7kDQ7gGqwrUW9N533rajr83pWYqqS7DYK9Nhm
 YfjA7hkfDApyGyJgabrB3CpGJAn/4dk5rC7ONsD1R2Wea8mTNfFlbGZUXeE6dtHg5/5HKzy7omkf
 cfvyLUQsGNnLQQEKAPVycHpNkMsdYdYViUH5lBntSNIJf905Rh1zcbojhob4LwaQIY6E5eAKaMt6
 b4k1NoSFJFCVSIPr0zwB5AZk00wXVLcKmo38g7RPhAba+msTFsjrVYmqAZI2rRe6eLfTXQfSfNuQ
 w4=
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:85r4eKOnKRQ=:Z9z1d4GjwwE1xIaITpqV2l
 ASuAaHuIprE+mtN4PIPeyOC5xXR1G1YO/S1BoK84gO0MiHenaN/q9r3oIBHELGQyAnHhrHAZa
 7EILeek7KVRw9aY7vrtwf4B4RGEy2PiD5cQ7vNLYSdr05rukjppBla9EPkNRIiH4LlxmHd9l/
 98ydmCgXHnH7DXVh+xZNNauGoFuBYtCxOJts5ZmagrBM40jdp//G36GRXroC1l8i2QmrPoCOY
 tdXDLfCzajMX6Nzv0qkoUdN7jnF4qrz0+cETR+07UvHX0ma8zC2VepfpRxzwzBBpZE6MN5nQR
 Q0n2VTdZ4PpXoPDMiEoHxc0E9OeJaRPOqHCIuA/+ThWGyb1b1YtciyeiSPsnWWS4XzMV7EcBX
 vdCb3qHKqSUHBZjfZWSfGign4OtDeyVi5oFBWcZ6eqx+Qd61ct02rcdirTRJX6C44PocFPO0q
 45Nm/70fjhmfIh6K7kKdG7GEbWti5+ZLnjgwvxWgU4g22VwUNIVvQeJpKscyqvbyDp4PqB/Am
 p3MSaPyY1NbqfTLGnf4gXbuWepMn82+AVUY1NKVL+2Sw0ovvQg0ddKCjxUgL77rMpHcrwZVn/
 /iVBGQVvft9+M=
Subject: Re: [PATCH] CryptoPkg: Fix various typos
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 17:05:04 -0000
Content-Type: text/plain; charset=UTF-8


> My wonder is about what is the correct use between succeeds/succeeded,
> I'd expect the following diff:
> 
> - @retval TRUE The time convertion succeeds.
> + @retval TRUE The time conversion succeeded.

In doubt, I'll just ignore this one. I made a v2 to address Jian review.
Thank you for reviewing this package.

Coeur