From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ACC02941A3A for ; Wed, 17 Jan 2024 14:12:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=b8DNjwbY9Lt18R7twDpWJUkDB2pyhY5GRWceOEK2QpA=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1705500727; v=1; b=I8MOoAjne7vnLPcqc5gAFF7h0P309awJmGhEvxWM7EvaXqBNgPPPk62uvyZZQLN48D7RgZtq BxWUEf+E2PGxSRCk0dxNTN6TiKUCAAuXW4ZNFUrU3a6Xx/HjltvZ8feCHw3GFo2/yLjUY65YAM8 jT7HFl4DVlBWyadTKqOj2BaI= X-Received: by 127.0.0.2 with SMTP id DPRoYY7687511xAb5pstQLnN; Wed, 17 Jan 2024 06:12:07 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.3010.1705500726679609184 for ; Wed, 17 Jan 2024 06:12:06 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-xToixmUPORqsNY6RMbTeuw-1; Wed, 17 Jan 2024 09:12:03 -0500 X-MC-Unique: xToixmUPORqsNY6RMbTeuw-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 987141C0BB4B for ; Wed, 17 Jan 2024 14:12:03 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7235F492BC9; Wed, 17 Jan 2024 14:12:03 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 75CDE1800DC8; Wed, 17 Jan 2024 15:12:02 +0100 (CET) Date: Wed, 17 Jan 2024 15:12:02 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Oliver Steffen Subject: Re: [edk2-devel] [PATCH 2/2] OvmfPkg/Tcg2Config: remove unused TPM 1.2 support Message-ID: References: <20240116154229.554679-1-kraxel@redhat.com> <20240116154229.554679-3-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Q7NMXMR2kgIpGtdxhlFeJJQ4x7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=I8MOoAjn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > This patch is good: > > Reviewed-by: Laszlo Ersek > > but the series shouldn't stop here. In "OvmfPkg/Tcg/Tcg2Config", we're > left with an INF file (Tcg2ConfigPei.inf) that still references > "Tpm12Support.h", and the common C source file "Tcg2ConfigPeim.c" still > calls the one API -- InternalTpm12Detect() -- declared in that header > file. The only remaining implementation of InternalTpm12Detect() is now > in "Tpm12SupportNull.c", and all it does is "return EFI_UNSUPPORTED". > > Therefore, in a subsequent patch, "Tpm12SupportNull.c" and > "Tpm12Support.h" should be removed, both from the tree, and from the > remaining INF file. Furthermore, the InternalTpm12Detect() call in > "Tcg2ConfigPeim.c", and everything that depends on the success of that > call, now counts as dead code, and should be removed. > > And *that* in turn means that we should also remove > "gEfiTpmDeviceInstanceTpm12Guid" from the [Guids] section of the > remaining INF file. Yes, I noticed there is more to cleanup, but I wanted have something quick and proven (== identical to setting TPM1_ENABLE=FALSE) out of the door to fix the build / CI problems. Touching the code for additional cleanups requires a bit more attention and testing, I'll keep that on my radar though. thanks & take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113951): https://edk2.groups.io/g/devel/message/113951 Mute This Topic: https://groups.io/mt/103764205/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-