From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8ADD1AC0B97 for ; Fri, 26 Jan 2024 13:25:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6E23xbl+OxoO7j6ijPvCHxfjPAFWg9eRMCHM88Lv40o=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706275543; v=1; b=aZ7Y/W7NonJ7enuItIgpHK2cP/QByCuylY+u6yaQJQ7ReZMQr1tc3sjXNez72Cr5ZzrJec/r M6orqbTv7snfRZNj+hFmsxGs2XaQgi6PA9Epkz4p1h05hwdt200ZNZN1Gh/WWfUQGy3vUIUWjFc C4gr/Pg2j+wcPDqF5+Y5mTNc= X-Received: by 127.0.0.2 with SMTP id kXMMYY7687511xLqA0hvMTro; Fri, 26 Jan 2024 05:25:43 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.15750.1706275542369945465 for ; Fri, 26 Jan 2024 05:25:42 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-hIrodHEGNNKJwx3yrQMkfg-1; Fri, 26 Jan 2024 08:25:36 -0500 X-MC-Unique: hIrodHEGNNKJwx3yrQMkfg-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30E57827D85; Fri, 26 Jan 2024 13:25:36 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 090272166B32; Fri, 26 Jan 2024 13:25:36 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 20F771800605; Fri, 26 Jan 2024 14:25:35 +0100 (CET) Date: Fri, 26 Jan 2024 14:25:35 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: Erdem Aktas , Tom Lendacky , devel@edk2.groups.io, Jiewen Yao , Ard Biesheuvel , Michael Roth , Min Xu , Oliver Steffen Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/ResetVector: send post codes to qemu debug console Message-ID: References: <20240124153107.2112760-1-kraxel@redhat.com> <67da33f7-5038-6732-455a-2576f641f1c0@redhat.com> <4d8b55a7-0898-4ab3-90d0-394b3bd533de@amd.com> <05f60909-a4ef-7497-5925-775b3ad71797@redhat.com> MIME-Version: 1.0 In-Reply-To: <05f60909-a4ef-7497-5925-775b3ad71797@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0Zw4VlD2i5oPmBcCs2NY8f81x7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="aZ7Y/W7N"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Jan 25, 2024 at 08:47:56PM +0100, Laszlo Ersek wrote: > On 1/25/24 08:50, Gerd Hoffmann wrote: > > On Wed, Jan 24, 2024 at 05:43:29PM -0800, Erdem Aktas wrote: > >> Same for TDX, I did not run it but it should cause failure > >> as debugShowPostCode is called OvmfPkg/ResetVector/Ia32/IntelTdx.asm before > >> actually the #VE handlers are installed. > >> > >>> Had a meeting get canceled and so got a chance to test this. As I thought, > >>> this causes SEV-ES/SEV-SNP guest failures. > > > > Hmm, I guess that pretty much kills the idea. The first post code is > > sent before probing for TDX/SEV happens ... > > Can we salvage it, but make it depend on a minimal source code tweak > (ungating)? Changing a single line for debugging (non-TDX / non-SEV-ES > guests, anyway) is much easier than coming up with this patch from zero, > whenever needed. > > Can we add "DebugCon.asm" to the tree, plus a *comment* near > > %include "DebugDisabled.asm" > > about "DebugCon.asm"? Sure, can do that. I assume the concern about the slowdown is moot if this requires an source code patch to be enabled? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114610): https://edk2.groups.io/g/devel/message/114610 Mute This Topic: https://groups.io/mt/103933942/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-