From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Yin Wang <yin.wang@intel.com>
Cc: devel@edk2.groups.io, ard.biesheuvel@arm.com,
jordan.l.justen@intel.com, sunilvl@ventanamicro.com
Subject: Re: [edk2-devel] [PATCH] OvmfPkg:Fix Hii form name mismatch with EFI variable
Date: Wed, 19 Jul 2023 15:48:19 +0200 [thread overview]
Message-ID: <ujpo344gku22jwqjsukrjruswlhegmmbi4yoqipnyozphsv7r7@q4chh3dexfjt> (raw)
In-Reply-To: <1764780e0f2ebce561f7c9fafb2a225706a50348.1689752592.git.yin.wang@intel.com>
On Wed, Jul 19, 2023 at 03:45:20PM +0800, Yin Wang wrote:
> Onemore need change beside 16acacf24c ("OvmfPkg: fix PlatformConfig")
>
> Find by sct cases:ExtractConfigConformance
> ExtractConfigFunction
> ExtractConfig_Func fail on RiscVVirtQemu.
> ConfigRequestHdr = HiiConstructConfigHdr (
> &gOvmfPlatformConfigGuid,
> - mVariableName,
> + mHiiFormName,
Ok.
> Status = gRT->SetVariable (
> - mVariableName,
> + mHiiFormName,
> Status = GetVariable2 (
> - mVariableName,
> + mHiiFormName,
That looks wrong to me.
With only riscv failing I suspect some setup code is missing in the
riscv build.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107054): https://edk2.groups.io/g/devel/message/107054
Mute This Topic: https://groups.io/mt/100231365/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-07-19 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 7:45 [edk2-devel] [PATCH] OvmfPkg:Fix Hii form name mismatch with EFI variable Wang, Yin
2023-07-19 13:48 ` Gerd Hoffmann [this message]
2023-07-19 14:06 ` Wang, Yin
2023-07-20 1:02 ` Wang, Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ujpo344gku22jwqjsukrjruswlhegmmbi4yoqipnyozphsv7r7@q4chh3dexfjt \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox