From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68587AC166E for ; Wed, 19 Jul 2023 13:48:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DG7qdunM0Xxmyz4VFOrQZfpwZ5x5TAbBiumHX2WlUuU=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-Received:X-MC-Unique:X-Received:X-Received:X-Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:X-Scanned-By:X-Mimecast-Spam-Score:X-Mimecast-Originator:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:X-Gm-Message-State:Content-Type:Content-Disposition; s=20140610; t=1689774507; v=1; b=i0mJXk1jdXjsx9NJ9fLB+ONzpBBQTqhpFK/NgrjUsFWYbGfqgW5qQeff2gtrgSn2IF35evMj k+oPTXYIWek/J6vqlkfoUA1ObczpqB7O79FmX0u18BGSx5wtEUxA53/Ge3tPB9qITnehgzBI2hW gLcJ49hCQ1OZ2VjP0KP7Euhg= X-Received: by 127.0.0.2 with SMTP id Ki73YY7687511xBkpUQoSHgy; Wed, 19 Jul 2023 06:48:27 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.14135.1689774506184012117 for ; Wed, 19 Jul 2023 06:48:26 -0700 X-Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-54-XY9LhHPmMvy2PQRGTKo1wg-1; Wed, 19 Jul 2023 09:48:22 -0400 X-MC-Unique: XY9LhHPmMvy2PQRGTKo1wg-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6E1BD29AA2D2; Wed, 19 Jul 2023 13:48:21 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 394EF1454142; Wed, 19 Jul 2023 13:48:21 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BA09D1800613; Wed, 19 Jul 2023 15:48:19 +0200 (CEST) Date: Wed, 19 Jul 2023 15:48:19 +0200 From: "Gerd Hoffmann" To: Yin Wang Cc: devel@edk2.groups.io, ard.biesheuvel@arm.com, jordan.l.justen@intel.com, sunilvl@ventanamicro.com Subject: Re: [edk2-devel] [PATCH] OvmfPkg:Fix Hii form name mismatch with EFI variable Message-ID: References: <1764780e0f2ebce561f7c9fafb2a225706a50348.1689752592.git.yin.wang@intel.com> MIME-Version: 1.0 In-Reply-To: <1764780e0f2ebce561f7c9fafb2a225706a50348.1689752592.git.yin.wang@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com X-Gm-Message-State: LwGo4eV21hiVhA7V1zjqyk6jx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=i0mJXk1j; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Jul 19, 2023 at 03:45:20PM +0800, Yin Wang wrote: > Onemore need change beside 16acacf24c ("OvmfPkg: fix PlatformConfig") > > Find by sct cases:ExtractConfigConformance > ExtractConfigFunction > ExtractConfig_Func fail on RiscVVirtQemu. > ConfigRequestHdr = HiiConstructConfigHdr ( > &gOvmfPlatformConfigGuid, > - mVariableName, > + mHiiFormName, Ok. > Status = gRT->SetVariable ( > - mVariableName, > + mHiiFormName, > Status = GetVariable2 ( > - mVariableName, > + mHiiFormName, That looks wrong to me. With only riscv failing I suspect some setup code is missing in the riscv build. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107054): https://edk2.groups.io/g/devel/message/107054 Mute This Topic: https://groups.io/mt/100231365/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-