From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.5908.1681365968250329820 for ; Wed, 12 Apr 2023 23:06:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AG6XQr1y; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681365967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pzl++KDQZ9YQgu50lGegmsQdF0wVkZ3AQKKwyohQcoQ=; b=AG6XQr1yU3o2JH/VY1Dh5w/VwvcFcZM3qHBo/6RtCw257O8jnzDVpkmr6rNdMusQ3qenWX QgQVsWqCifm/Yz74dd8rHPO8Giv73smpaSpIA4q44J1MRjtiWAkRxACq4UijNOX9EMPrb7 Z6UvHj7mkVwxc2x0h8KVSadL1VnCpQ8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-599-ZJ_jQaPnPuWyIl-xmSbO7w-1; Thu, 13 Apr 2023 02:06:02 -0400 X-MC-Unique: ZJ_jQaPnPuWyIl-xmSbO7w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 795A888904B; Thu, 13 Apr 2023 06:06:01 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BDC22166B26; Thu, 13 Apr 2023 06:06:01 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id AC35A18000A3; Thu, 13 Apr 2023 08:05:59 +0200 (CEST) Date: Thu, 13 Apr 2023 08:05:59 +0200 From: "Gerd Hoffmann" To: Tom Lendacky Cc: "Xu, Min M" , joeyli , "devel@edk2.groups.io" , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Michael Roth Subject: Re: [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest Message-ID: References: <5d170680-0a9e-2d5f-ecc1-e9f587548e3c@amd.com> <7a06aa46-4c10-fc85-48a6-826a4d82991e@amd.com> <2xjjrifeaa7khaha4se7gs3hmtdz2kkg2dv4t7njwf5z5mbn2f@qb5s2k7c6225> <03fed1d7-cbd8-ee45-ebd8-8ecf60971e61@amd.com> MIME-Version: 1.0 In-Reply-To: <03fed1d7-cbd8-ee45-ebd8-8ecf60971e61@amd.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > > > Specifying both OVMF_CODE.fd and OVMF_VARS.fd generates an ASSERT. > > > > Both as pflash I assume? Which assert? > > Yes, both as pflash. I've never attempted to run an SEV guest using the > -bios option. > > The assert is: > ASSERT [PlatformPei] /root/kernels/ovmf-build-X64/OvmfPkg/Library/PlatformInitLib/Platform.c(930): ((BOOLEAN)(0==1)) Ok, so wrong encryption settings. > > > Specifying just OVMF.fd boots successfully > > > > pflash or -bios or both? > > Just pflash. /me looks surprised. It should not make a difference whenever you use the separate OVMF_CODE.fd + OVMF_VARS.fd files or the combined OVMF.fd. What are the exact qemu command lines for both cases? > I believe none of the mappings are setup properly at this point. I > think just eliminating the call for an SEV guest is fine. Can AmdSevInitialize() setup the mappings? take care, Gerd