From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, lichao@loongson.cn
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Bibo Mao <maobibo@loongson.cn>,
Dongyan Qian <qiandongyan@loongson.cn>
Subject: Re: [edk2-devel] [PATCH v1 16/26] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull
Date: Fri, 15 Mar 2024 10:22:09 +0100 [thread overview]
Message-ID: <ulom3nr2ep5t33nktcm32ok2ksvtceub5m5sxsigixk4hi3fhj@5pegoeweljmj> (raw)
In-Reply-To: <20240311093857.1254256-1-lichao@loongson.cn>
On Mon, Mar 11, 2024 at 02:39:02AM -0700, Chao Li wrote:
> This Library is used to collect APs resources, but is currently NULL
> for OvmfPkg, because it is not used by the LoongArch virtual machine.
What is the point of having this library then?
> +#include <PiPei.h>
> +#include <Library/BaseLib.h>
> +#include <Library/HobLib.h>
> +#include <Library/MemoryAllocationLib.h>
> +#include <Register/LoongArch64/Csr.h>
> +#include "../../../UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.h"
Including private header files of other libraries looks questionable.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116789): https://edk2.groups.io/g/devel/message/116789
Mute This Topic: https://groups.io/mt/104859891/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-15 9:22 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 9:36 [edk2-devel] [PATCH v1 00/26] Part 2 patch set to enable LoongArch virtual machine in edk2 Chao Li
2024-03-11 9:37 ` [edk2-devel] [PATCH v1 01/26] UefiCpuPkg/CpuTimerLib: Reorder the INF file alphabetically Chao Li
2024-03-14 10:48 ` Gerd Hoffmann
2024-03-11 9:37 ` [edk2-devel] [PATCH v1 02/26] UefiCpuPkg/CpuExceptionHandlerLib: Reorder the INF files alphabetically Chao Li
2024-03-14 10:49 ` Gerd Hoffmann
2024-03-11 9:37 ` [edk2-devel] [PATCH v1 03/26] UefiCpuPkg/MpInitLib: " Chao Li
2024-03-14 10:52 ` Gerd Hoffmann
2024-03-15 6:16 ` Chao Li
2024-03-11 9:37 ` [edk2-devel] [PATCH v1 04/26] UefiCpuPkg/CpuDxe: Reorder the INF file alphabetically Chao Li
2024-03-14 10:59 ` Gerd Hoffmann
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 05/26] UefiCpuPkg: Add LoongArch64 CPU Timer instance Chao Li
2024-03-14 10:59 ` Gerd Hoffmann
2024-03-15 6:37 ` Chao Li
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 06/26] UefiCpuPkg: Add CPU exception library for LoongArch Chao Li
2024-03-14 11:22 ` Gerd Hoffmann
2024-03-15 6:20 ` Chao Li
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 07/26] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg Chao Li
2024-03-14 11:28 ` Gerd Hoffmann
2024-03-15 6:29 ` Chao Li
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 08/26] UefiCpuPkg: Added a new PCD named PcdCpuExceptionVectorBaseAddress Chao Li
2024-03-14 11:44 ` Gerd Hoffmann
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 09/26] UefiCpuPkg: Added a new PCD named PcdCpuMmuIsEnabled Chao Li
2024-03-15 9:09 ` Gerd Hoffmann
2024-03-15 9:30 ` Chao Li
2024-03-15 10:21 ` Gerd Hoffmann
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 10/26] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg Chao Li
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 11/26] UefiCpuPkg: Add CpuMmuInitLib.h " Chao Li
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 12/26] UefiCpuPkg: Add CpuMmuInitLib " Chao Li
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 13/26] UefiCpuPkg: Add multiprocessor library for LoongArch64 Chao Li
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 14/26] UefiCpuPkg: Add CpuDxe driver " Chao Li
2024-03-11 9:38 ` [edk2-devel] [PATCH v1 15/26] OvmfPkg/LoongArchVirt: Add stable timer driver Chao Li
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 16/26] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull Chao Li
2024-03-15 9:22 ` Gerd Hoffmann [this message]
2024-04-12 8:34 ` Chao Li
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 17/26] OvmfPkg/LoongArchVirt: Add serial port hook library Chao Li
2024-03-15 9:24 ` Gerd Hoffmann
2024-03-15 9:33 ` Gerd Hoffmann
2024-03-15 9:46 ` Chao Li
2024-03-15 9:51 ` Ard Biesheuvel
2024-03-15 9:54 ` Chao Li
[not found] ` <17BCE78056888EC1.6435@groups.io>
2024-03-20 9:36 ` Chao Li
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 18/26] OvmfPkg/LoongArchVirt: Add the early serial port output library Chao Li
2024-03-15 9:36 ` Gerd Hoffmann
2024-03-15 10:19 ` Chao Li
2024-03-15 10:34 ` Gerd Hoffmann
2024-03-15 11:07 ` Chao Li
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 19/26] OvmfPkg/LoongArchVirt: Add real time clock library Chao Li
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib Chao Li
2024-03-15 9:40 ` Gerd Hoffmann
2024-03-16 10:19 ` xianglai
2024-03-18 15:21 ` Gerd Hoffmann
2024-03-19 2:04 ` Chao Li
2024-03-19 8:03 ` Gerd Hoffmann
2024-03-19 9:10 ` Chao Li
2024-03-19 9:29 ` Gerd Hoffmann
2024-05-06 10:02 ` Chao Li
2024-05-06 10:24 ` Ard Biesheuvel
2024-05-07 2:25 ` Chao Li
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib Chao Li
2024-03-15 9:53 ` Gerd Hoffmann
[not found] ` <01d94c67-de3d-7709-84d4-ec97dc7a01ec@loongson.cn>
2024-03-18 15:28 ` Gerd Hoffmann
2024-03-19 2:10 ` Chao Li
2024-03-20 10:16 ` Gerd Hoffmann
2024-03-21 1:38 ` Chao Li
2024-03-21 11:39 ` Gerd Hoffmann
2024-03-21 12:27 ` Chao Li
[not found] ` <17BEC74BB37915EC.2828@groups.io>
2024-04-17 2:53 ` Chao Li
2024-04-17 6:59 ` Gerd Hoffmann
2024-04-17 7:43 ` Chao Li
2024-04-17 8:01 ` Gerd Hoffmann
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 22/26] OvmfPkg/LoongArchVirt: Add reset system library Chao Li
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 23/26] OvmfPkg/LoongArchVirt: Support SEC phase Chao Li
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 24/26] OvmfPkg/LoongArchVirt: Support PEI phase Chao Li
2024-03-11 9:39 ` [edk2-devel] [PATCH v1 25/26] OvmfPkg/LoongArchVirt: Add build file Chao Li
2024-03-11 9:40 ` [edk2-devel] [PATCH v1 26/26] OvmfPkg/LoongArchVirt: Add self introduction file Chao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ulom3nr2ep5t33nktcm32ok2ksvtceub5m5sxsigixk4hi3fhj@5pegoeweljmj \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox