From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5C963941350 for ; Fri, 15 Mar 2024 09:22:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=p5rudY5Ci37QULUw0bcTO8Oe8ySG8hpF156YWuTCdNY=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1710494538; v=1; b=SOT/GGcrEl3pRI3pqKt0jG6jibDyWYPT0ksQaffRogU9N0KS4QnX9ru2qfxlMfZP3LxGfotK HmnD/7OUbQBFR0lFJ670FQwyT+DiXm4AAhwP1Xl/cTHptGWvuM9e4iUkLNjwxFBGYCefwBGiO+9 tnNxvxKhgbtyarqxhhxdlsRf4aJI+88PibfJwLGpNlVbwol6qNJYwSKJjXdf5T33Q0grJK4NeDg 1UvNlYAE12vAxFH7csZWM5VeGh3rSduxHrlaxlf/5R/WXaZqZk1jQVIVzsL2Jm89SrMobt1DuYA wS1viEd63Nmhuy7i9nb+dLeKqQPx5rakDeSqsfhPr8HUQ== X-Received: by 127.0.0.2 with SMTP id s4qPYY7687511xV7uiM8gmpo; Fri, 15 Mar 2024 02:22:18 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.17295.1710494537407023286 for ; Fri, 15 Mar 2024 02:22:17 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-63-KtakrRG8OTaLUegTmJ1JEw-1; Fri, 15 Mar 2024 05:22:11 -0400 X-MC-Unique: KtakrRG8OTaLUegTmJ1JEw-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B769293249C; Fri, 15 Mar 2024 09:22:11 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F27C40C6DB3; Fri, 15 Mar 2024 09:22:11 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 07B631800DD4; Fri, 15 Mar 2024 10:22:10 +0100 (CET) Date: Fri, 15 Mar 2024 10:22:09 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, lichao@loongson.cn Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian Subject: Re: [edk2-devel] [PATCH v1 16/26] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull Message-ID: References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093857.1254256-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20240311093857.1254256-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 15 Mar 2024 02:22:17 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: f19VNlHokD3kzDPyv4oezJVpx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="SOT/GGcr"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Mar 11, 2024 at 02:39:02AM -0700, Chao Li wrote: > This Library is used to collect APs resources, but is currently NULL > for OvmfPkg, because it is not used by the LoongArch virtual machine. What is the point of having this library then? > +#include > +#include > +#include > +#include > +#include > +#include "../../../UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.h" Including private header files of other libraries looks questionable. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116789): https://edk2.groups.io/g/devel/message/116789 Mute This Topic: https://groups.io/mt/104859891/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-