From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EA905AC0E1B for ; Wed, 24 Jan 2024 11:39:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZD1O3HW9DOEa7TA2s5JYegX3I1lQ4NKlNiivpfxK12Y=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706096362; v=1; b=Oj8hl+5BkfSzDM/oaz+BAHmYF5uy/njiiVKUElkn82ByNtcX+VXLKg8ygrn1fGyr5p6PpRtg sLpj6ga4HItbIjC8WnJZVLw2Nkon/j6OUjgvFGeNgeSmABOTV90G46hbJRngQQoCmfi3RCriVwB wDanwyK/uUrovFSGHpXeFYV0= X-Received: by 127.0.0.2 with SMTP id TsnJYY7687511x3aGDLifWXI; Wed, 24 Jan 2024 03:39:22 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.20562.1706096361754723568 for ; Wed, 24 Jan 2024 03:39:21 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-5FKh0t1DOcKztNI9L4PSLw-1; Wed, 24 Jan 2024 06:39:17 -0500 X-MC-Unique: 5FKh0t1DOcKztNI9L4PSLw-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CBEC085A589; Wed, 24 Jan 2024 11:39:16 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA6C13C2E; Wed, 24 Jan 2024 11:39:16 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B6083180038B; Wed, 24 Jan 2024 12:39:15 +0100 (CET) Date: Wed, 24 Jan 2024 12:39:15 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, dougflick@microsoft.com Cc: "Douglas Flick [MSFT]" , Saloni Kasbekar , Zachary Clark-williams Subject: Re: [edk2-devel] [PATCH 02/14] NetworkPkg: Dhcp6Dxe: SECURITY PATCH CVE-2023-45230 Unit Tests Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 72AcH79KToHpxcg6UDNqJJ8Ax7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Oj8hl+5B; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Jan 23, 2024 at 07:33:25PM -0800, Doug Flick via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4535 > > SECURITY PATCH - Unit Tests > > TCBZ4535 > CVE-2023-45230 > CVSS 8.3 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:H > CWE-119 Improper Restriction of Operations within the Bounds > of a Memory Buffer I don't think this is needed here, this patch doesn't fix CVE-2023-45230 after all. A description of what the tests are checking would be more useful. > diff --git a/NetworkPkg/NetworkPkg.ci.yaml b/NetworkPkg/NetworkPkg.ci.yaml > index 07dc7abd6938..0060f7a2cb8f 100644 > --- a/NetworkPkg/NetworkPkg.ci.yaml > +++ b/NetworkPkg/NetworkPkg.ci.yaml > @@ -7,73 +7,65 @@ > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > { > - "LicenseCheck": { > - "IgnoreFiles": [] > - }, > + "LicenseCheck": { "IgnoreFiles": [] }, I guess this patch hooks the unit tests into CI. The whitespace changes make changes file hard to read though. Two options to deal with that: (1) avoid to reformat the file, or (2) split the patch into two, one with only the whitespace changes and one with the functional change. thanks & take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114276): https://edk2.groups.io/g/devel/message/114276 Mute This Topic: https://groups.io/mt/103926732/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-