Re: [edk2-devel] [PATCH 4/4] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too

["Gerd Hoffmann" <kraxel@redhat.com>]

On Fri, Jan 12, 2024 at 01:16:47PM +0100, Ard Biesheuvel wrote:
> On Fri, 12 Jan 2024 at 12:38, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > It is possible to find variable entries with State being 0xff,
> > i.e. not updated since flash block erase.   This indicates the
> > header write was not completed (and therefore State was not set
> > to VAR_HEADER_VALID_ONLY).  Treat this as additional "end of
> > variable list" condition.
> >
> 
> Why?

This can happen only at the end of the variable list, when the variable
driver tried to append a new entry but was interrupted early.

Also without a valid header you don't have NameSize and DataSize.  So
you can't calculate the size of the entry to continue following the
chain.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113731): https://edk2.groups.io/g/devel/message/113731
Mute This Topic: https://groups.io/mt/103680936/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-