From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DE39FAC10C3 for ; Fri, 12 Jan 2024 12:41:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=l1as43dC+FA+JtWr4xY+dDlv3jMzH4LUqw/+08pw99w=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1705063287; v=1; b=gRL6Q4jYYYX7097/o+MhqBJ158MQa8b0dSfCHHKXSeyLo8oFmyDwzo0ygoqRroYTJ4hnu0Ly 8TjAydgNnhkfopKc9KpglFNTeSKLTKWnAviAhS1gMmgZToDMzm+RLlozLSbG42kK2l0EznOmanQ RNqYBC7CLDYI7cW/fJ6Joc0k= X-Received: by 127.0.0.2 with SMTP id 75HpYY7687511xWb6b5CdhEW; Fri, 12 Jan 2024 04:41:27 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.5998.1705063286923075676 for ; Fri, 12 Jan 2024 04:41:27 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-_sdNOIO3MfeYtIm1m_dwjg-1; Fri, 12 Jan 2024 07:41:24 -0500 X-MC-Unique: _sdNOIO3MfeYtIm1m_dwjg-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D84FA185A781; Fri, 12 Jan 2024 12:41:23 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.233]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A7691121313; Fri, 12 Jan 2024 12:41:23 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6377D180079A; Fri, 12 Jan 2024 13:41:22 +0100 (CET) Date: Fri, 12 Jan 2024 13:41:22 +0100 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Laszlo Ersek , Jiewen Yao , oliver@redhat.com Subject: Re: [edk2-devel] [PATCH 4/4] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too Message-ID: References: <20240112113754.14710-1-kraxel@redhat.com> <20240112113754.14710-5-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EGOs0xxvFlCw0UW85HsLpgwLx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=gRL6Q4jY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Jan 12, 2024 at 01:16:47PM +0100, Ard Biesheuvel wrote: > On Fri, 12 Jan 2024 at 12:38, Gerd Hoffmann wrote: > > > > It is possible to find variable entries with State being 0xff, > > i.e. not updated since flash block erase. This indicates the > > header write was not completed (and therefore State was not set > > to VAR_HEADER_VALID_ONLY). Treat this as additional "end of > > variable list" condition. > > > > Why? This can happen only at the end of the variable list, when the variable driver tried to append a new entry but was interrupted early. Also without a valid header you don't have NameSize and DataSize. So you can't calculate the size of the entry to continue following the chain. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113731): https://edk2.groups.io/g/devel/message/113731 Mute This Topic: https://groups.io/mt/103680936/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-