From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io
Subject: Re: heap/page guard broken on aarch64
Date: Wed, 12 Jul 2023 15:26:14 +0200 [thread overview]
Message-ID: <uylhozyupscbpjqco5mgnyrmeceobhbhl5vxw5mrbrglq2aefl@dhyp6xzioho7> (raw)
In-Reply-To: <CAMj1kXHszFoXUAzjP1ydewh1sSxBDyS8qDBMo7gN121c+e4Sgg@mail.gmail.com>
On Wed, Jul 12, 2023 at 02:03:37PM +0200, Ard Biesheuvel wrote:
> On Wed, 12 Jul 2023 at 10:41, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > PcdHeapGuardPageType=0x7e
> > PcdHeapGuardPoolType=0x7e
> This looks like the debug 'poison' value is applied to the freed guard
> page before the EFI_MEMORY_RP permission is removed.
>
> I wonder if the 'IsGuarded' logic in CoreFreePoolI is wrong here: this
> is runtime memory, which is rounded up to 64k granularity on AArch64,
> and I would not be surprised if that code is buggy.
Looks plausible to me. Tried fix AdjustPoolHeadF() to use granularity
instead of efi page size, that alone didn't make the firmware boot
though.
Clearing the two runtime memory type bits (0x7e -> 0x1e) makes the
firmware boot.
take care,
Gerd
next prev parent reply other threads:[~2023-07-12 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 8:41 heap/page guard broken on aarch64 Gerd Hoffmann
2023-07-12 12:03 ` Ard Biesheuvel
2023-07-12 13:26 ` Gerd Hoffmann [this message]
2023-07-12 21:20 ` [edk2-devel] " Oliver Smith-Denny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uylhozyupscbpjqco5mgnyrmeceobhbhl5vxw5mrbrglq2aefl@dhyp6xzioho7 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox