From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 323FE74004F for ; Thu, 2 May 2024 09:06:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GKZovFdM2q00YtwQ5laSiX+RACXfil7q9RI7YHoyVCw=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1714640817; v=1; b=zuPGLoSZ7htBPKPEE9C2RGFmFtZ22q5fhPzzLFajFqpImujZseGaa1PgsnwmK24EyQy+//vb O1iiULQg7cQMkBIijgUatuY0R2G2YAvEuj5SYIMWYHxw/V/tObHBOlxHNhQle16/X7Zz1a9v/pg CgS3SX1kmZ7qQ4P3uUfG24Va+fd4nQP4t94ICeLOsbhPrjpc2FRQmxQLhr2pC4UrV97IrAC7TLS QEX9L3k4Yc3R6u4dwLIS3XhYYW1bptVbCvhKgScImLq4MDXzqyXvA/VuJHtZM63whtnLbw6K962 xhCBPBYytMXTXf/7wstKS7PCXJsjAO/50mPmOXUqooTBg== X-Received: by 127.0.0.2 with SMTP id Hom5YY7687511xKUFmGSWTrB; Thu, 02 May 2024 02:06:57 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.894.1714640816932305818 for ; Thu, 02 May 2024 02:06:57 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-GwuY95noPd-fpA8KIvW4Tw-1; Thu, 02 May 2024 05:06:52 -0400 X-MC-Unique: GwuY95noPd-fpA8KIvW4Tw-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8ECC83810B05; Thu, 2 May 2024 09:06:52 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.194.0]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5EAAE2166B31; Thu, 2 May 2024 09:06:52 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 0B0031196F0; Thu, 2 May 2024 11:06:51 +0200 (CEST) Date: Thu, 2 May 2024 11:06:51 +0200 From: "Gerd Hoffmann" To: Michael Roth Cc: devel@edk2.groups.io, Ard Biesheuvel , Tom Lendacky Subject: Re: [edk2-devel] [PATCH v4 0/3] OvmfPkg: Don't make APIC MMIO accesses with encryption bit set Message-ID: References: <20240501190340.2238565-1-michael.roth@amd.com> MIME-Version: 1.0 In-Reply-To: <20240501190340.2238565-1-michael.roth@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 02:06:57 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PfV0N4HaBel7z84m6GOv1srmx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=zuPGLoSZ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, May 01, 2024 at 02:03:37PM GMT, Michael Roth wrote: > For the most part, OVMF will clear the encryption bit for MMIO regions, > but there is currently one known exception during SEC when the APIC > base address is accessed via MMIO with the encryption bit set for > SEV-ES/SEV-SNP guests. In the case of SEV-SNP, this requires special > handling on the hypervisor side which may not be available in the > future[1], so make the necessary changes in the SEC-configured page > table to clear the encryption bit for 4K region containing the APIC > base address. > > Since CpuPageTableLib is used to handle the splitting, some additional > care must be taken to clear the C-bit in all non-leaf PTEs since the > library expects that to be the case. Add handling for that when setting > up the SEC page table. > > While here, drop special handling for the APIC base address in the > SEV-ES/SNP #VC handler. Series: Reviewed-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118502): https://edk2.groups.io/g/devel/message/118502 Mute This Topic: https://groups.io/mt/105849106/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-