From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 87DB7740041 for ; Mon, 27 May 2024 06:38:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=n5mz0Rq/0kUSX4Z7L+TvsTNRNhAQ/jOuYUCi6E7s9gk=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240206; t=1716791912; v=1; b=cSZpJx7i2QzXPslcyky4bl7WuCy8xkxtIh82oxNRVvAnE4x+xMQgluZ5v4oQL4aKrDnfqa9E dHTez55BRj/fmnwA5Emn6PQqBdxGsPZAJwWBbF8ZWjyWodf2QY3Hfy1/TLKBCv3DZMmJwKKSc2T GWJ7jUsVpN9EBajN3g6fBsAho7G1F+T1DRvffMTiAnJwFpTtIRsE7kt2pSc4kBIQ2G7oE0saepa YKIQz8J5q3eOgwFC+f1a/X/SGphMfKPEUAJfivUpDKhQ3GE6/KYMkGMPjmgO4yY93aR9Rk9iBsR RA3rp5OE/GzAx/Fyny9ErFbO6YjhFPqcSeqniI4b2WvKg== X-Received: by 127.0.0.2 with SMTP id 7kTgYY7687511x3g1E7u1stR; Sun, 26 May 2024 23:38:31 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.22018.1716791910501486983 for ; Sun, 26 May 2024 23:38:30 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-T9acEhJjPOumqVWW_4Aoig-1; Mon, 27 May 2024 02:38:25 -0400 X-MC-Unique: T9acEhJjPOumqVWW_4Aoig-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F31B29AA39C; Mon, 27 May 2024 06:38:25 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7B2C492BC6; Mon, 27 May 2024 06:38:24 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A2EB41800DD9; Mon, 27 May 2024 08:38:23 +0200 (CEST) Date: Mon, 27 May 2024 08:38:23 +0200 From: "Gerd Hoffmann" To: Marcin Juszkiewicz Cc: devel@edk2.groups.io, lichao@loongson.cn, Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Jiewen Yao , Xianglai Li Subject: Re: [edk2-devel] [PATCH v1 1/2] OvmfPkg: Add no hardcode version of FtdNorFlashQemuLib Message-ID: References: <20240517071729.188409-1-lichao@loongson.cn> <20240517071754.188521-1-lichao@loongson.cn> <314a58cc-9add-493e-a3d7-fd77edf77999@linaro.org> MIME-Version: 1.0 In-Reply-To: <314a58cc-9add-493e-a3d7-fd77edf77999@linaro.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 26 May 2024 23:38:30 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZRdGaGPEflvscT9j3ExZE088x7686176AA= Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=cSZpJx7i; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, May 24, 2024 at 11:11:41AM GMT, Marcin Juszkiewicz wrote: > W dniu 17.05.2024 o 09:17, Chao Li via groups.io pisze: > > This library is copied from ArmVirtPkg, in the Arm version, the value of > > PcdFlashNvStorageVariableBase, PcdFlashNvStorageFtwWorkingBase and > > PcdFlashNvStorageFtwSpareBase are hardcoded in INC file. > > > > This version will calculate them from FDT resource and using the set PCD > > to store when the NorFlashInitialise is called. By default, the first > > available flash(not used for storage UEFI code) as NV variable storage > > medium. > > > > In this way, UEFI can better handle the change of flash base address, > > which is suitable for different cpu architecture board implementation. > > > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4770 > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Sami Mujawar > > Cc: Gerd Hoffmann > > Cc: Jiewen Yao > > Signed-off-by: Chao Li > > Signed-off-by: Xianglai Li > > Can you split it into driver itself and part which uses DT data to setup > parameters? Hmm? This split exists already. This is a library for flash detection, which is used by the flash driver (VirtNorFlashDxe) to find flash. If using fdt doesn't work for sbsa-ref you can implement an alternative without rewriting the driver itself. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119275): https://edk2.groups.io/g/devel/message/119275 Mute This Topic: https://groups.io/mt/106149595/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-