From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8C7217803EB for ; Fri, 27 Oct 2023 11:04:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xM0tIY7blfPP0iyYhetJKmseToW7+Wnm88VedYtV+VM=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1698404698; v=1; b=oq0LwnLoS7Qwy0TuKB3FduEpYUaRtRHm4wCe5xRkqXrCXpu8KynBMd/X56IRNEPZ6oEE8rEN b4RCY3cXl0Nhtn0g3fFlehnGZ6YPSAoTGb82TMKl29uTMAPXP5vM1zCqE9K2isJZ2C9QrqYC1Sh Z/wwxghWp39g+/v+D77TMSOM= X-Received: by 127.0.0.2 with SMTP id C7EDYY7687511xi3CfsDQUAs; Fri, 27 Oct 2023 04:04:58 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.4392.1698404697362968771 for ; Fri, 27 Oct 2023 04:04:57 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-xSaxvo-qPve4hYJmuzJxMA-1; Fri, 27 Oct 2023 07:04:42 -0400 X-MC-Unique: xSaxvo-qPve4hYJmuzJxMA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 123BA29ABA1F; Fri, 27 Oct 2023 11:04:42 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D69AC1121319; Fri, 27 Oct 2023 11:04:41 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9C23518011F2; Fri, 27 Oct 2023 13:04:40 +0200 (CEST) Date: Fri, 27 Oct 2023 13:04:40 +0200 From: "Gerd Hoffmann" To: sunceping Cc: devel@edk2.groups.io, Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , Tom Lendacky , Michael Roth Subject: Re: [edk2-devel] [PATCH V1 2/2] OvmfPkg/BaseMemEncryptTdxLib: Handle retry result of MapGPA Message-ID: References: <20231027005738.371-1-cepingx.sun@intel.com> <20231027005738.371-3-cepingx.sun@intel.com> MIME-Version: 1.0 In-Reply-To: <20231027005738.371-3-cepingx.sun@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dt4kvEqsvjyexpU3LwNuyDMDx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oq0LwnLo; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > + while (RetryCount < MAX_RETRIES_PER_PAGE) { > + TdStatus = TdVmCallMapGPA (PhysicalAddress, Length, &MapGpaRetryaddr); > + if (TdStatus != TDVMCALL_STATUS_RETRY) { > + break; > + } > + > + DEBUG ((DEBUG_VERBOSE, "%a: TdVmcall(MAPGPA) Retry PhysicalAddress is %llx, MapGpaRetryaddr is %llx\n", __func__, PhysicalAddress, MapGpaRetryaddr)); > + > + EndAddress = PhysicalAddress + Length; The end address doesn't change, you can move that out of the loop. > + if ((MapGpaRetryaddr < PhysicalAddress) || (MapGpaRetryaddr > EndAddress)) { > + DEBUG ((DEBUG_ERROR, "%a: TdVmcall(MAPGPA) failed Retry PhysicalAddress is %llx, MapGpaRetryaddr is %llx\n", __func__, PhysicalAddress, MapGpaRetryaddr)); > + break; > + } The error message is misleading. The actual problem is that the 'PhysicalAddress <= MapGpaRetryaddr <= EndAddress' sanity check failed. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110202): https://edk2.groups.io/g/devel/message/110202 Mute This Topic: https://groups.io/mt/102212640/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-