From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.45796.1683195088312387086 for ; Thu, 04 May 2023 03:11:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D9jFI20t; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683195087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UFiQAhw4F9hhnfUqJ6mqUjXiRQLrAXHJPTdi85IHSZI=; b=D9jFI20t+3/qkhE0deYG0G9dtp3NWqq9YO3f4Vtbe4JsoIczxAFJRq0LGfyVdak9XyaXRZ CX+4LvSLH0hS8Kfqf9UMW4AfQXgY5flxqJ8Ctvw6XQPVfvHHJ1SvWUAQWZzxvmY+N9Lwme LAWG5s6dMCPXCuF/rQOa6+en/Ijccps= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-164-B4KB70RgNuelNEUaaOM8gA-1; Thu, 04 May 2023 06:11:21 -0400 X-MC-Unique: B4KB70RgNuelNEUaaOM8gA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 804D9811E7B; Thu, 4 May 2023 10:11:20 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 812A72166B30; Thu, 4 May 2023 10:11:19 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 30DCB1800922; Thu, 4 May 2023 12:11:18 +0200 (CEST) Date: Thu, 4 May 2023 12:11:18 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Yuwei Chen , Oliver Steffen , Bob Feng , Marvin =?utf-8?Q?H=C3=A4user?= , Daniel Schaefer , Chao Li , Dongyan Qian , Michael D Kinney , Pawel Polawski , Baoqi Zhang , Leif Lindholm , Rebecca Cran , Zhiguang Liu , Sunil V L , Ard Biesheuvel , Liming Gao Subject: Re: [PATCH v5 00/10] BaseTools: remove duplicate includes. Message-ID: References: <20230421044535.4030762-1-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230421044535.4030762-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Ping. On Fri, Apr 21, 2023 at 06:45:25AM +0200, Gerd Hoffmann wrote: > There is alot of code duplication between BaseTools and MdePkg (and also > MdeModulePkg). This patch series starts reducing this by removing some > header files. BaseTools are switched over to use the include files in > MdePkg instead. It also cleans up some (apparently) obsolete code and > adapts BaseTools code in a few places to work with the MdePkg version of > the include files. > > v5 changes: > - remove visibility hidden on x64 > - add assert for GOT being empty. > v4 changes: > - fix clang build failure > v3 changes: > - fix build failure on ubuntu 22.04 > v2 changes: > - rebase to latest master, resolve conflicts. > - pick up reviews and acks. > > take care, > Gerd > > Gerd Hoffmann (10): > BaseTools: make sure the got is empty > MdePkg: don't set visibility to hidden > BaseTools: remove WinNtInclude.h > BaseTools: remove duplicate includes: /ProcessorBind.h > BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h > MdePkg/PeImage.h: add bits from BaseTools version > BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks > BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_* > BaseTools: remove duplicate includes: IndustryStandard/PeImage.h > BaseTools: remove duplicate includes: IndustryStandard/*.h > > BaseTools/Source/C/Common/WinNtInclude.h | 66 -- > BaseTools/Source/C/EfiRom/EfiRom.h | 14 +- > .../Source/C/Include/AArch64/ProcessorBind.h | 148 ---- > .../Source/C/Include/Arm/ProcessorBind.h | 147 ---- > .../Source/C/Include/Ia32/ProcessorBind.h | 155 ---- > .../Source/C/Include/IndustryStandard/Acpi.h | 117 --- > .../C/Include/IndustryStandard/Acpi1_0.h | 285 ------- > .../C/Include/IndustryStandard/Acpi2_0.h | 520 ------------ > .../C/Include/IndustryStandard/Acpi3_0.h | 668 --------------- > .../C/Include/IndustryStandard/Bluetooth.h | 56 -- > .../C/Include/IndustryStandard/EfiPci.h | 51 -- > ...emoryMappedConfigurationSpaceAccessTable.h | 39 - > .../C/Include/IndustryStandard/PeImage.h | 789 ------------------ > .../Source/C/Include/IndustryStandard/pci22.h | 536 ------------ > .../Source/C/Include/IndustryStandard/pci23.h | 18 - > .../Source/C/Include/IndustryStandard/pci30.h | 38 - > .../C/Include/LoongArch64/ProcessorBind.h | 80 -- > .../Source/C/Include/Protocol/DevicePath.h | 2 +- > .../Source/C/Include/RiscV64/ProcessorBind.h | 85 -- > .../Source/C/Include/X64/ProcessorBind.h | 183 ---- > MdePkg/Include/IndustryStandard/PeImage.h | 31 + > MdePkg/Include/X64/ProcessorBind.h | 14 - > BaseTools/Source/C/Common/BasePeCoff.c | 51 +- > BaseTools/Source/C/Common/Decompress.c | 1 + > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 43 +- > BaseTools/Source/C/GenFw/Elf32Convert.c | 8 +- > BaseTools/Source/C/GenFw/Elf64Convert.c | 12 +- > BaseTools/Source/C/GenFw/ElfConvert.c | 2 - > BaseTools/Source/C/GenFw/GenFw.c | 18 +- > BaseTools/Scripts/ClangBase.lds | 10 + > BaseTools/Scripts/GccBase.lds | 10 + > BaseTools/Source/C/Makefiles/header.makefile | 15 +- > BaseTools/Source/C/Makefiles/ms.common | 13 +- > 33 files changed, 132 insertions(+), 4093 deletions(-) > delete mode 100644 BaseTools/Source/C/Common/WinNtInclude.h > delete mode 100644 BaseTools/Source/C/Include/AArch64/ProcessorBind.h > delete mode 100644 BaseTools/Source/C/Include/Arm/ProcessorBind.h > delete mode 100644 BaseTools/Source/C/Include/Ia32/ProcessorBind.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi1_0.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi2_0.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi3_0.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Bluetooth.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/EfiPci.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/PeImage.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci22.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci23.h > delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci30.h > delete mode 100644 BaseTools/Source/C/Include/LoongArch64/ProcessorBind.h > delete mode 100644 BaseTools/Source/C/Include/RiscV64/ProcessorBind.h > delete mode 100644 BaseTools/Source/C/Include/X64/ProcessorBind.h > > -- > 2.40.0 > --