public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: devel@edk2.groups.io, "Laszlo Ersek" <lersek@redhat.com>,
	"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
	"Jiewen Yao" <jiewen.yao@intel.com>,
	"Erdem Aktas" <erdemaktas@google.com>,
	"James Bottomley" <jejb@linux.ibm.com>,
	"Min Xu" <min.m.xu@intel.com>,
	"Tom Lendacky" <thomas.lendacky@amd.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Rebecca Cran" <rebecca@bsdio.com>,
	"Peter Grehan" <grehan@freebsd.org>,
	"Corvin Köhne" <corvink@freebsd.org>,
	"Sebastien Boeuf" <sebastien.boeuf@intel.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Julien Grall" <julien@xen.org>
Subject: Re: [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one
Date: Thu, 11 May 2023 06:53:39 +0200	[thread overview]
Message-ID: <xctd3iokds7u35y5rqchassntzpz3uwzki3b7tk5mfuloxe52b@lj44bfiyhyeb> (raw)
In-Reply-To: <20230509163212.291333-1-pedro.falcato@gmail.com>

On Tue, May 09, 2023 at 05:32:00PM +0100, Pedro Falcato wrote:
> This patch-set replaces the OVMF specific SataControllerDxe with the MdeModulePkg/Bus/Pci one.
> They were both forked from the same code, and are code-and-functionality similar. As such, there
> seems to be no need for duplication here.
> 
> The first four pages both replay OvmfPkg/SataControllerDxe commits and fix up a couple of details.
> The rest of the patches (minus the last) replace OvmfPkg/SataControllerDxe with the MdeModulePkg variant.
> The last patch, finally, removes the thing.
> 
> Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)).
> More testing from other, alternative platforms is desired, although breakage seems unlikely.
> 
> This patchset (or at least, the last patch) depends on the edk2-platforms patch series to get merged.
> 
> (+CC Laszlo as the author of the original SataControllerDxe patches)
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc :Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Cc: Corvin Köhne <corvink@freebsd.org>
> Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Laszlo Ersek <lersek@redhat.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>


  parent reply	other threads:[~2023-05-11  4:53 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 16:32 [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one Pedro Falcato
2023-05-09 16:32 ` [PATCH v2 01/12] MdeModulePkg/SataControllerDxe: Clean up error handling in Start() Pedro Falcato
2023-05-10  8:30   ` Laszlo Ersek
2023-05-12  1:35   ` [edk2-devel] " Wu, Hao A
2023-05-09 16:32 ` [PATCH v2 02/12] MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO level Pedro Falcato
2023-05-10  8:32   ` Laszlo Ersek
2023-05-12  1:35   ` Wu, Hao A
2023-05-09 16:32 ` [PATCH v2 03/12] MdeModulePkg/SataControllerDxe: Remove useless null check Pedro Falcato
2023-05-10  8:33   ` Laszlo Ersek
2023-05-12  1:35   ` [edk2-devel] " Wu, Hao A
2023-05-09 16:32 ` [PATCH v2 04/12] MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private != NULL) Pedro Falcato
2023-05-10  8:45   ` Laszlo Ersek
2023-05-12  1:36   ` Wu, Hao A
2023-05-09 16:32 ` [PATCH v2 05/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe Pedro Falcato
2023-05-10  8:48   ` Laszlo Ersek
2023-05-09 16:32 ` [PATCH v2 06/12] OvmfPkg/Microvm: " Pedro Falcato
2023-05-10  8:48   ` Laszlo Ersek
2023-05-09 16:32 ` [PATCH v2 07/12] OvmfPkg/Bhyve: " Pedro Falcato
2023-05-10  8:49   ` Laszlo Ersek
2023-05-11 11:58     ` [edk2-devel] " Corvin Köhne
2023-05-09 16:32 ` [PATCH v2 08/12] OvmfPkg/CloudHv: " Pedro Falcato
2023-05-09 16:32 ` [PATCH v2 09/12] OvmfPkg/IntelTdx: " Pedro Falcato
2023-05-09 16:32 ` [PATCH v2 10/12] OvmfPkg/AmdSev: " Pedro Falcato
2023-05-09 16:32 ` [PATCH v2 11/12] OvmfPkg/Xen: " Pedro Falcato
2023-05-12 14:14   ` Anthony PERARD
2023-05-09 16:32 ` [PATCH v2 12/12] OvmfPkg: Remove SataControllerDxe Pedro Falcato
2023-05-10  8:50   ` Laszlo Ersek
2023-05-10  6:49 ` [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one Ard Biesheuvel
2023-05-11  4:53 ` Gerd Hoffmann [this message]
2023-06-01 16:12 ` Ard Biesheuvel
2023-06-01 17:12   ` Pedro Falcato
2023-06-01 17:13     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xctd3iokds7u35y5rqchassntzpz3uwzki3b7tk5mfuloxe52b@lj44bfiyhyeb \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox