From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.51929.1683780827667217997 for ; Wed, 10 May 2023 21:53:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZbhCu/mi; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683780826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K6m0xaRyD8OjsqT4hIcZ4CsCUPG023WuCsfgIpfqhhY=; b=ZbhCu/miTt65c4ByYVAwvVZnspUcTKCBhFvFRvFQfb6Yl9b0o1ARDUj0oLnJBW2KxTCARf oxRxpI6JsuU5xIIh5npuFBHTGJXB/DnbD7/4DNTWKX862NetC+uf9yxit22Szzfs7ztb86 pxdRhozOrv484EwuDj0gxN2gc+1w8Bo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-538-Ubs8mVz8N3S5RRWwBsVcaA-1; Thu, 11 May 2023 00:53:42 -0400 X-MC-Unique: Ubs8mVz8N3S5RRWwBsVcaA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9A08B1C0512B; Thu, 11 May 2023 04:53:41 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34C6918EC1; Thu, 11 May 2023 04:53:41 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4F3401801258; Thu, 11 May 2023 06:53:39 +0200 (CEST) Date: Thu, 11 May 2023 06:53:39 +0200 From: "Gerd Hoffmann" To: Pedro Falcato Cc: devel@edk2.groups.io, Laszlo Ersek , Ard Biesheuvel , Jiewen Yao , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , Corvin =?utf-8?B?S8O2aG5l?= , Sebastien Boeuf , Anthony Perard , Julien Grall Subject: Re: [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one Message-ID: References: <20230509163212.291333-1-pedro.falcato@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230509163212.291333-1-pedro.falcato@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, May 09, 2023 at 05:32:00PM +0100, Pedro Falcato wrote: > This patch-set replaces the OVMF specific SataControllerDxe with the MdeModulePkg/Bus/Pci one. > They were both forked from the same code, and are code-and-functionality similar. As such, there > seems to be no need for duplication here. > > The first four pages both replay OvmfPkg/SataControllerDxe commits and fix up a couple of details. > The rest of the patches (minus the last) replace OvmfPkg/SataControllerDxe with the MdeModulePkg variant. > The last patch, finally, removes the thing. > > Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). > More testing from other, alternative platforms is desired, although breakage seems unlikely. > > This patchset (or at least, the last patch) depends on the edk2-platforms patch series to get merged. > > (+CC Laszlo as the author of the original SataControllerDxe patches) > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc :Jordan Justen > Cc: Gerd Hoffmann > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Min Xu > Cc: Tom Lendacky > Cc: Michael Roth > Cc: Rebecca Cran > Cc: Peter Grehan > Cc: Corvin Köhne > Cc: Sebastien Boeuf > Cc: Anthony Perard > Cc: Julien Grall > Cc: Laszlo Ersek Acked-by: Gerd Hoffmann