From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24])
by mx.groups.io with SMTP id smtpd.web10.18386.1684232525496606952
for <devel@edk2.groups.io>;
Tue, 16 May 2023 03:22:05 -0700
Authentication-Results: mx.groups.io;
dkim=pass header.i=@xora.org.uk header.s=fm2 header.b=QqlZEdy3;
spf=pass (domain: xora.org.uk, ip: 64.147.123.24, mailfrom: graeme@xora.org.uk)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
by mailout.west.internal (Postfix) with ESMTP id C53FB3200C08;
Tue, 16 May 2023 06:18:31 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute5.internal (MEProxy); Tue, 16 May 2023 06:18:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xora.org.uk; h=
cc:cc:content-type:content-type:date:date:from:from:in-reply-to
:in-reply-to:message-id:mime-version:references:reply-to:sender
:subject:subject:to:to; s=fm2; t=1684232311; x=1684318711; bh=/D
lsuqkFPUHfG+RFYfZ9m60c8xAJY1vOXjl0bpfk/DQ=; b=QqlZEdy30riBIiRrGq
PlXGML2OZBJL/cD/9jVZ4dFzetvIbOaS+dkA5iELPx3R12qMzduSPWDBrhj4bm31
rHP0Zk0vTGC3dyZi+04eBSLz6mDys0egnu652lmlxOV0gumSTI+r9vWryZj4reCI
UfMT6Jvq9vPqHP/yLVGr2x5rZIumjfrR4z0bLCoJJqycHWytQgPZzn72wGp//G0I
ccYSolPS1gC2QhOxhf8Cr7+8gZFTnaON4ars/lQlYbzmIGgdRhrDxAE7RLjpYZny
sb27oy+9wudpwPt8nkaVfgJ0ooWoMACZSjdZc45YhDwflkWv9ar4bxUkdNrsfBFH
yIwg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:sender:subject
:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; t=1684232311; x=1684318711; bh=/DlsuqkFPUHfG
+RFYfZ9m60c8xAJY1vOXjl0bpfk/DQ=; b=LGVqvUMr3TNgYbfk05XgqBEIfI9eo
KTjQp3Sos85GQocimXhbt+zXnd7wDP4tTfgUPsxfZiHKymExi6oS/D/QsnBjp/QV
UYgEPKw+8wfQzGzU1QVU2LM6WQN/ksFaOKuDUU3kN7bEXnKkDAgpBilrBJD1Wp10
VZMlEhSS/9jI89y9DCirtC7a8MGR6uVIcdDApCNe3+9mqt6KUAljpH9gQ1YMQCuU
SJqcQu/URJ96fNovj39lf/C3SvR+R+vcGAMJc34QWdk0TLlQ0rwQJ3l82UfwqmNo
tLMIn3U5pvuHQ0HFsYDSUKU3V27wi/DWIvd60OS1oqd6iPcR8Lz9RMfgQ==
X-ME-Sender: <xms:d1hjZEP__4xJfcqvQbZCR6fZXOHHVkkoWl985UW1g8Ov6HSfCCSZOg>
<xme:d1hjZK_9D7zaEsqRR9t-eLz-LH1nLKPUkSjzDJhbVYVvQ5qVKtEYbwvul6ZSfulK6
NUAcdiCzvgmKLOybw>
X-ME-Received: <xmr:d1hjZLSVbge50zHS3PjKqSrnujhLQA2c53tZ06iLkLtnN7OCEcSJ9cMv>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehledgvdejucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddtvdenucfhrhhomhepifhrrggv
mhgvucfirhgvghhorhihuceoghhrrggvmhgvseigohhrrgdrohhrghdruhhkqeenucggtf
frrghtthgvrhhnpeeffeeggfegueeuudelffehjedtuddvudevffelheduffeikeeuffff
kefhkeefffenucffohhmrghinhepghhrohhuphhsrdhiohenucevlhhushhtvghrufhiii
gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgrvghmvgesgihorhgrrdhorhhg
rdhukh
X-ME-Proxy: <xmx:d1hjZMvhaOMpoodHNT1jc1qEPaltRpZWZi__dsY5cjxkF8C2nx_gjQ>
<xmx:d1hjZMdJ7HviAAHtStyv0r5ZKS-PUnB8zlYC7MnJxGu3hs8MHODRNQ>
<xmx:d1hjZA3QPiRwk8K5aDfLrVQ-xYR3vQY2pkIXtJ4h6W--BB1mzOtBzg>
<xmx:d1hjZE5K2rkh1tpLzKu8vDS7sFJjnK-jhFkOyczfHHdvIHfO-aRvlQ>
Feedback-ID: i62f7400e:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
16 May 2023 06:18:30 -0400 (EDT)
Date: Tue, 16 May 2023 11:18:28 +0100
From: "Graeme Gregory" <graeme@xora.org.uk>
To: devel@edk2.groups.io, quic_llindhol@quicinc.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Radoslaw Biernacki <rad@semihalf.com>, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] SbsaQemu: make GIC base address Pcds dynamic
Message-ID: <xgt5wtogotsnkyjtprsdffjfdbhmi3znuxzwbs22wgqn2f6e6g@i7wsumcfequy>
References: <20230512175753.13318-1-quic_llindhol@quicinc.com>
MIME-Version: 1.0
In-Reply-To: <20230512175753.13318-1-quic_llindhol@quicinc.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Fri, May 12, 2023 at 06:57:51PM +0100, Leif Lindholm wrote:
> Currently, the GIC and redistributors base addresses are defined using
> FixedPcds.
>
> In order to enable the QEMU platform to evolve to provide ITS frames,
> as well as newer versions of the GIC, convert these accesses to Dynamic.
>
> Firtsly, this requires fixing the bug of the addresses being read as 32-bit
> Pcds, and then moving the declarations and calls to the dynamic form.
>
Messed this up first time, so...
All patches look good to me.
Reviewed-by: Graeme Gregory <graeme@xora.org.uk>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Graeme Gregory <graeme@xora.org.uk>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>
> Leif Lindholm (2):
> Silicon/Qemu: use 64-bit Pcds for SbsaQemu GIC addresses
> Silicon/Qemu: use dynamic Pcds for SbsaQemu GIC addresses
>
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 12 ++++++------
> Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 7 ++++---
> .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 5 +++--
> .../SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 2 +-
> .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +-
> 5 files changed, 15 insertions(+), 13 deletions(-)
>
> --
> 2.30.2
>
>
>
>
>
>