From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, "Pawel Polawski" <ppolawsk@redhat.com>,
"Dongyan Qian" <qiandongyan@loongson.cn>,
"Sunil V L" <sunilvl@ventanamicro.com>,
"Baoqi Zhang" <zhangbaoqi@loongson.cn>,
"Chao Li" <lichao@loongson.cn>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Yuwei Chen" <yuwei.chen@intel.com>,
"Marvin Häuser" <mhaeuser@posteo.de>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Daniel Schaefer" <git@danielschaefer.me>,
"Bob Feng" <bob.c.feng@intel.com>,
"Oliver Steffen" <osteffen@redhat.com>
Subject: Re: [edk2-devel] [PATCH v4 08/10] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_*
Date: Fri, 14 Apr 2023 16:39:25 +0200 [thread overview]
Message-ID: <xli5qg46ptfts6uc3qtzrwjwar6tgvuo32jfsx5o2kqtmnq6sr@pytcbm5jm4wc> (raw)
In-Reply-To: <c32846b0-dae8-14bc-bd87-96a442f0fb7b@bsdio.com>
On Fri, Apr 14, 2023 at 06:16:52AM -0600, Rebecca Cran wrote:
> On 4/14/23 02:02, Gerd Hoffmann wrote:
>
> > diff --git a/BaseTools/Source/C/Include/IndustryStandard/PeImage.h b/BaseTools/Source/C/Include/IndustryStandard/PeImage.h
> > index 22161edf443d..fb867b5660a9 100644
> > --- a/BaseTools/Source/C/Include/IndustryStandard/PeImage.h
> > +++ b/BaseTools/Source/C/Include/IndustryStandard/PeImage.h
> > @@ -42,6 +42,7 @@
> > #define IMAGE_FILE_MACHINE_X64 0x8664
> > #define IMAGE_FILE_MACHINE_ARM 0x01c0 // Thumb only
> > #define IMAGE_FILE_MACHINE_ARMT 0x01c2 // 32bit Mixed ARM and Thumb/Thumb 2 Little Endian
> > +#define IMAGE_FILE_MACHINE_ARMTHUMB_MIXED IMAGE_FILE_MACHINE_ARMT
> > #define IMAGE_FILE_MACHINE_ARM64 0xAA64 // 64bit ARM Architecture, Little Endian
> > #define IMAGE_FILE_MACHINE_RISCV64 0x5064 // 64bit RISC-V ISA
> > #define IMAGE_FILE_MACHINE_LOONGARCH64 0x6264 // 64bit LoongArch Architecture
>
> Has this passed CI/uncrustify? I think it would complain about the alignment
> here.
CI doesn't complain, but I think BaseTools are excluded from uncrustify
checking.
take care,
Gerd
next prev parent reply other threads:[~2023-04-14 14:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 8:02 [PATCH v4 00/10] BaseTools: remove duplicate includes Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 01/10] BaseTools: add BASETOOLS define Gerd Hoffmann
2023-04-14 12:29 ` Marvin Häuser
2023-04-14 14:37 ` Gerd Hoffmann
2023-04-14 14:51 ` Marvin Häuser
2023-04-14 14:57 ` [edk2-devel] " Ard Biesheuvel
2023-04-14 15:10 ` Marvin Häuser
2023-04-18 11:52 ` Gerd Hoffmann
2023-04-18 11:59 ` Ard Biesheuvel
2023-04-18 13:20 ` Gerd Hoffmann
2023-04-18 13:41 ` Marvin Häuser
2023-04-18 15:50 ` Ard Biesheuvel
2023-04-21 3:26 ` 回复: " gaoliming
2023-05-22 12:27 ` Gerd Hoffmann
2023-05-22 12:55 ` Ard Biesheuvel
2023-05-22 13:38 ` Gerd Hoffmann
2023-05-22 14:31 ` Gerd Hoffmann
2023-05-23 7:07 ` Ard Biesheuvel
2023-05-23 8:49 ` Gerd Hoffmann
2023-05-23 8:54 ` Ard Biesheuvel
2023-04-14 8:02 ` [PATCH v4 02/10] MdePkg: don't set visibility to hidden for BaseTools Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 03/10] BaseTools: remove WinNtInclude.h Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 04/10] BaseTools: remove duplicate includes: <arch>/ProcessorBind.h Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 05/10] BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 06/10] MdePkg/PeImage.h: add bits from BaseTools version Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 07/10] BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 08/10] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_* Gerd Hoffmann
2023-04-14 12:16 ` [edk2-devel] " Rebecca Cran
2023-04-14 14:39 ` Gerd Hoffmann [this message]
2023-04-14 8:02 ` [PATCH v4 09/10] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 10/10] BaseTools: remove duplicate includes: IndustryStandard/*.h Gerd Hoffmann
2023-04-14 12:18 ` [edk2-devel] [PATCH v4 00/10] BaseTools: remove duplicate includes Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xli5qg46ptfts6uc3qtzrwjwar6tgvuo32jfsx5o2kqtmnq6sr@pytcbm5jm4wc \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox