From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.13366.1687872446533693281 for ; Tue, 27 Jun 2023 06:27:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Oq6Pk3tG; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687872445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hMwDKHdZtT6wCR5iNWqJtEEMPbW/E+MWJU6S42hiXDA=; b=Oq6Pk3tGDRBxHXHl5bRvWxAvModMshTJNQdVm87y5vqnA/AjUbl7wjM7xlBFnqSC9x3cBM C4XCWFzwJE7btlMPH9VbdCCsfxsItT/6lb1FFbcoUR4nF40SbpNY2f+FC6TqllFfA5vO31 1+ju+WmFMZtOS6UQylDRGXhRzF8QtBc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-OD2JEu1gPQyC9pL7QGilIw-1; Tue, 27 Jun 2023 09:27:23 -0400 X-MC-Unique: OD2JEu1gPQyC9pL7QGilIw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 20BC5381D1E6; Tue, 27 Jun 2023 13:27:22 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED18C400F5A; Tue, 27 Jun 2023 13:27:21 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id AE9EA1800606; Tue, 27 Jun 2023 15:27:20 +0200 (CEST) Date: Tue, 27 Jun 2023 15:27:20 +0200 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH] OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call Message-ID: References: <20230627111716.1022950-1-ardb@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230627111716.1022950-1-ardb@kernel.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 27, 2023 at 01:17:16PM +0200, Ard Biesheuvel wrote: > The UEFI driver model invokes the supported() method on every driver > every time a connection attempt is made on any handle, and so doing an > unconditional DEBUG() print inside this method produced a lot of noise. > > So let's drop this DEBUG() call from the VirtioSerial driver's > Supported() method. > > Signed-off-by: Ard Biesheuvel Acked-by: Gerd Hoffmann