From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Guo, Gua" <gua.guo@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Mathews, John" <john.mathews@intel.com>,
"Zimmer, Vincent" <vincent.zimmer@intel.com>,
Sami Mujawar <sami.mujawar@arm.com>,
"jmaloy@redhat.com" <jmaloy@redhat.com>
Subject: Re: [edk2-devel] [PATCH v3 0/4] Bz4166: Integer Overflow in CreateHob()
Date: Wed, 24 Jan 2024 13:48:17 +0100 [thread overview]
Message-ID: <y3chnvsokeu3rax6nlu5jdc3imlbgpo55z5il4cwunj7gpf57l@w2ux7ofghllx> (raw)
In-Reply-To: <BL1PR11MB5478DF992B86013455EF61E7EF742@BL1PR11MB5478.namprd11.prod.outlook.com>
On Tue, Jan 23, 2024 at 03:16:32PM +0000, Guo, Gua wrote:
> For MdeModulePkg, I think no need to change because no any logic change.
>
> For StandaloneMmPkg and EmbeddedPkg
> - Don't have enough abilities to close Sami Mujawar and Ni Ray open currently, so hold on the change until I find how to introduce Panic. So give up these two packages patch currently.
On StandaloneMmPkg: I think the patch is fine, I've replied in that
subthread.
On EmbeddedPkg: I think the BuildGuidDataHob() callsites need review
whenever they do:
(a) check the return value properly, or
(b) allocate a fixed size HOB so the new check in CreateHob() can't
fail.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114284): https://edk2.groups.io/g/devel/message/114284
Mute This Topic: https://groups.io/mt/103675959/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-24 12:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 2:25 [edk2-devel] [PATCH v3 0/4] Bz4166: Integer Overflow in CreateHob() Guo, Gua
2024-01-12 2:25 ` [edk2-devel] [PATCH v3 1/4] UefiPayloadPkg/Hob: " Guo, Gua
2024-01-12 2:25 ` [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Hob: " Guo, Gua
2024-01-12 8:56 ` Ni, Ray
2024-01-24 12:40 ` Gerd Hoffmann
2024-01-25 1:33 ` Ni, Ray
2024-01-12 2:25 ` [edk2-devel] [PATCH v3 3/4] EmbeddedPkg/Hob: " Guo, Gua
2024-01-12 2:25 ` [edk2-devel] [PATCH v3 4/4] MdeModulePkg/Hob: " Guo, Gua
2024-01-16 14:39 ` 回复: " gaoliming via groups.io
2024-01-19 9:53 ` [edk2-devel] [PATCH v3 0/4] Bz4166: " Sami Mujawar
2024-01-23 14:49 ` Gerd Hoffmann
2024-01-23 15:16 ` Guo, Gua
2024-01-24 12:48 ` Gerd Hoffmann [this message]
2024-01-25 8:08 ` Guo, Gua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y3chnvsokeu3rax6nlu5jdc3imlbgpo55z5il4cwunj7gpf57l@w2ux7ofghllx \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox