From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3684C7803CD for ; Wed, 24 Jan 2024 12:48:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Esg0v8LAz2vKSoUdzfA5ndeUiv6PwWOQCf5I0VNJ97o=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706100501; v=1; b=gJ3NNE8UQOaEVQGqO6CFWBFMpUNnY5w+NQ+H7CDYNpJBJTcSrH0TBpn/txYJenobur7pQ8B5 aFZBYc/1QJhrlDvrz2/nCU+4W7bF/VwuKf12xhqQxIE0JrIY+5pT457egzcw2dV4/2cnRxcTO2W oY3m/mF5pmt0euzfETpN6s9Y= X-Received: by 127.0.0.2 with SMTP id Zu1NYY7687511xr7Q6m8PiPh; Wed, 24 Jan 2024 04:48:21 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.21504.1706100501081267802 for ; Wed, 24 Jan 2024 04:48:21 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-tEZGGnkANJGYgG1ESIGwsw-1; Wed, 24 Jan 2024 07:48:19 -0500 X-MC-Unique: tEZGGnkANJGYgG1ESIGwsw-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92A2688F9E1; Wed, 24 Jan 2024 12:48:18 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6DC121C060AF; Wed, 24 Jan 2024 12:48:18 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 44DDF180038B; Wed, 24 Jan 2024 13:48:17 +0100 (CET) Date: Wed, 24 Jan 2024 13:48:17 +0100 From: "Gerd Hoffmann" To: "Guo, Gua" Cc: "devel@edk2.groups.io" , Ard Biesheuvel , "Mathews, John" , "Zimmer, Vincent" , Sami Mujawar , "jmaloy@redhat.com" Subject: Re: [edk2-devel] [PATCH v3 0/4] Bz4166: Integer Overflow in CreateHob() Message-ID: References: <20240112022521.710-1-gua.guo@intel.com> <7nmqqmemymehgdglvwh52kotfbo2b5hoktqo3enus63aqs4wc5@2jhpeq4q2bfa> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WKXmOFPyXugU2ssyRwb13tCax7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=gJ3NNE8U; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Jan 23, 2024 at 03:16:32PM +0000, Guo, Gua wrote: > For MdeModulePkg, I think no need to change because no any logic change. > > For StandaloneMmPkg and EmbeddedPkg > - Don't have enough abilities to close Sami Mujawar and Ni Ray open currently, so hold on the change until I find how to introduce Panic. So give up these two packages patch currently. On StandaloneMmPkg: I think the patch is fine, I've replied in that subthread. On EmbeddedPkg: I think the BuildGuidDataHob() callsites need review whenever they do: (a) check the return value properly, or (b) allocate a fixed size HOB so the new check in CreateHob() can't fail. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114284): https://edk2.groups.io/g/devel/message/114284 Mute This Topic: https://groups.io/mt/103675959/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-