From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: devel@edk2.groups.io,
"Anthony Perard" <anthony.perard@citrix.com>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Jiewen Yao" <jiewen.yao@intel.com>,
"Jordan Justen" <jordan.l.justen@intel.com>,
"Julien Grall" <julien@xen.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically
Date: Mon, 18 Sep 2023 09:00:58 +0200 [thread overview]
Message-ID: <ycybfvu33wh5ayisixkkdxooa6zi3fj663agh334tgdl4n6hi5@6m7kpeufj7tn> (raw)
In-Reply-To: <20230912141714.74953-1-lersek@redhat.com>
On Tue, Sep 12, 2023 at 04:17:14PM +0200, Laszlo Ersek wrote:
> "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro
> VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already
> use it (such as ArmVirtPkg/PlatformBootManagerLib,
> OvmfPkg/VirtioSerialDxe). We should use it in
> OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3.
> switch (VirtIo->SubSystemDeviceId) {
> - case 3:
> + case VIRTIO_SUBSYSTEM_CONSOLE:
> PrepareVirtioSerialDevicePath (Handle);
> break;
> default:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108767): https://edk2.groups.io/g/devel/message/108767
Mute This Topic: https://groups.io/mt/101315751/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-09-18 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 14:17 [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically Laszlo Ersek
2023-09-12 14:43 ` Laszlo Ersek
2023-09-12 14:56 ` Ard Biesheuvel
2023-09-18 7:00 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ycybfvu33wh5ayisixkkdxooa6zi3fj663agh334tgdl4n6hi5@6m7kpeufj7tn \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox