[edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically

[edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically

[Laszlo Ersek]

"OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro
VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already
use it (such as ArmVirtPkg/PlatformBootManagerLib,
OvmfPkg/VirtioSerialDxe). We should use it in
OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3.

Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien@xen.org>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>
Beautifies: 163083fd80d5
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
index 88c39df4aea9..d9f61757cf1b 100644
--- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
+++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
@@ -1250,7 +1250,7 @@ DetectAndPreparePlatformVirtioDevicePath (
   DEBUG ((DEBUG_INFO, "%a:%d: id %d\n", __func__, __LINE__, VirtIo->SubSystemDeviceId));
 
   switch (VirtIo->SubSystemDeviceId) {
-    case 3:
+    case VIRTIO_SUBSYSTEM_CONSOLE:
       PrepareVirtioSerialDevicePath (Handle);
       break;
     default:


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108534): https://edk2.groups.io/g/devel/message/108534
Mute This Topic: https://groups.io/mt/101315751/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically

[Laszlo Ersek]

On 9/12/23 16:17, Laszlo Ersek wrote:
> "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro
> VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already
> use it (such as ArmVirtPkg/PlatformBootManagerLib,
> OvmfPkg/VirtioSerialDxe). We should use it in
> OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3.
> 
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Beautifies: 163083fd80d5
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> index 88c39df4aea9..d9f61757cf1b 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> @@ -1250,7 +1250,7 @@ DetectAndPreparePlatformVirtioDevicePath (
>    DEBUG ((DEBUG_INFO, "%a:%d: id %d\n", __func__, __LINE__, VirtIo->SubSystemDeviceId));
>  
>    switch (VirtIo->SubSystemDeviceId) {
> -    case 3:
> +    case VIRTIO_SUBSYSTEM_CONSOLE:
>        PrepareVirtioSerialDevicePath (Handle);
>        break;
>      default:

Please ignore "1/2" in the subject prefix; that was a mistake on my end
(not passing "-N" to git-format-patch).

This patch stands alone.

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108537): https://edk2.groups.io/g/devel/message/108537
Mute This Topic: https://groups.io/mt/101315751/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically

[Ard Biesheuvel]

On Tue, 12 Sept 2023 at 16:18, Laszlo Ersek <lersek@redhat.com> wrote:
>
> "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro
> VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already
> use it (such as ArmVirtPkg/PlatformBootManagerLib,
> OvmfPkg/VirtioSerialDxe). We should use it in
> OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3.
>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Beautifies: 163083fd80d5
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>


> ---
>  OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> index 88c39df4aea9..d9f61757cf1b 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> @@ -1250,7 +1250,7 @@ DetectAndPreparePlatformVirtioDevicePath (
>    DEBUG ((DEBUG_INFO, "%a:%d: id %d\n", __func__, __LINE__, VirtIo->SubSystemDeviceId));
>
>    switch (VirtIo->SubSystemDeviceId) {
> -    case 3:
> +    case VIRTIO_SUBSYSTEM_CONSOLE:
>        PrepareVirtioSerialDevicePath (Handle);
>        break;
>      default:
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108538): https://edk2.groups.io/g/devel/message/108538
Mute This Topic: https://groups.io/mt/101315751/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically

[Gerd Hoffmann]

On Tue, Sep 12, 2023 at 04:17:14PM +0200, Laszlo Ersek wrote:
> "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro
> VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already
> use it (such as ArmVirtPkg/PlatformBootManagerLib,
> OvmfPkg/VirtioSerialDxe). We should use it in
> OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3.

>    switch (VirtIo->SubSystemDeviceId) {
> -    case 3:
> +    case VIRTIO_SUBSYSTEM_CONSOLE:
>        PrepareVirtioSerialDevicePath (Handle);
>        break;
>      default:

Acked-by: Gerd Hoffmann <kraxel@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108767): https://edk2.groups.io/g/devel/message/108767
Mute This Topic: https://groups.io/mt/101315751/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-