From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2F40194146C for ; Mon, 18 Sep 2023 07:01:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+WJHgCeqUEk4X3yJqXEbPfQj+gnVlSq2h3KltdZbQDo=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1695020467; v=1; b=faTefT+0cxx7F5HBrOspyX4k1f/oRTTabxRa1/+fBNONi7OxmaCSIgGumOE9cN8PQ0WYLy3D 5CDS4MwUmwXLXl2u0BlMsvImz1ULJaf7OYQUtMSfypT3UcoEZYNhDHLIxOe5bcPLGmDzB2RovhO 81lwswRdwIGs1cFjm/l81LXc= X-Received: by 127.0.0.2 with SMTP id JrvwYY7687511xOAEqxdrEWd; Mon, 18 Sep 2023 00:01:07 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.46021.1695020466257490885 for ; Mon, 18 Sep 2023 00:01:06 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-GOs7f4YHNF-_08TYGy-7Dw-1; Mon, 18 Sep 2023 03:01:02 -0400 X-MC-Unique: GOs7f4YHNF-_08TYGy-7Dw-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 295BD1818E42; Mon, 18 Sep 2023 07:01:01 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91E0040C6EA8; Mon, 18 Sep 2023 07:01:00 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 09E2018007A1; Mon, 18 Sep 2023 09:00:59 +0200 (CEST) Date: Mon, 18 Sep 2023 09:00:58 +0200 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Anthony Perard , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Julien Grall , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Stefan Berger Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically Message-ID: References: <20230912141714.74953-1-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230912141714.74953-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0XSegpsHeKZx1pDF2NI0NLU6x7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=faTefT+0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Sep 12, 2023 at 04:17:14PM +0200, Laszlo Ersek wrote: > "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro > VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already > use it (such as ArmVirtPkg/PlatformBootManagerLib, > OvmfPkg/VirtioSerialDxe). We should use it in > OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3. > switch (VirtIo->SubSystemDeviceId) { > - case 3: > + case VIRTIO_SUBSYSTEM_CONSOLE: > PrepareVirtioSerialDevicePath (Handle); > break; > default: Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108767): https://edk2.groups.io/g/devel/message/108767 Mute This Topic: https://groups.io/mt/101315751/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-