From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: "Marvin Häuser" <mhaeuser@posteo.de>,
"Ard Biesheuvel" <ardb@kernel.org>,
devel@edk2.groups.io, "Yuwei Chen" <yuwei.chen@intel.com>,
"Oliver Steffen" <osteffen@redhat.com>,
"Bob Feng" <bob.c.feng@intel.com>,
"Daniel Schaefer" <git@danielschaefer.me>,
"Chao Li" <lichao@loongson.cn>,
"Dongyan Qian" <qiandongyan@loongson.cn>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Pawel Polawski" <ppolawsk@redhat.com>,
"Baoqi Zhang" <zhangbaoqi@loongson.cn>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Sunil V L" <sunilvl@ventanamicro.com>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Liming Gao" <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH v5 02/10] MdePkg: don't set visibility to hidden
Date: Tue, 9 May 2023 08:08:24 +0200 [thread overview]
Message-ID: <yoxfsdhq23nsdtw22w3znxdoklxsy3z4c4zmqvnnpebgfllnyw@5mmdw5dnooti> (raw)
In-Reply-To: <5faf3ba0-0d75-f526-6491-30c2c96ad186@bsdio.com>
On Fri, May 05, 2023 at 08:33:41AM -0600, Rebecca Cran wrote:
> Gerd,
>
>
> Does this series need rework following this discussion, or is it ready to
> merge?
I think we are good to go. The ASSERT suggested by Ard here ...
>
> > > So it would be better to ASSERT() on non-empty GOT, and ignore such
> > > GOTPCREL relocations instead of attempting to relocate the GOT entries
> > > they (used to) refer to.
... is added to the linker scripts by patch #1 of the series.
take care,
Gerd
next prev parent reply other threads:[~2023-05-09 6:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 4:45 [PATCH v5 00/10] BaseTools: remove duplicate includes Gerd Hoffmann
2023-04-21 4:45 ` [PATCH v5 01/10] BaseTools: make sure the got is empty Gerd Hoffmann
2023-04-21 4:45 ` [PATCH v5 02/10] MdePkg: don't set visibility to hidden Gerd Hoffmann
2023-04-21 6:01 ` Marvin Häuser
2023-04-21 6:49 ` Gerd Hoffmann
2023-04-21 6:57 ` Marvin Häuser
2023-04-21 9:23 ` Gerd Hoffmann
2023-04-21 7:21 ` Ard Biesheuvel
2023-04-21 7:46 ` Marvin Häuser
2023-05-05 14:33 ` Rebecca Cran
2023-05-09 6:08 ` Gerd Hoffmann [this message]
2023-04-21 4:45 ` [PATCH v5 03/10] BaseTools: remove WinNtInclude.h Gerd Hoffmann
2023-04-21 4:45 ` [PATCH v5 04/10] BaseTools: remove duplicate includes: <arch>/ProcessorBind.h Gerd Hoffmann
2023-04-21 4:45 ` [PATCH v5 05/10] BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h Gerd Hoffmann
2023-04-21 4:45 ` [PATCH v5 06/10] MdePkg/PeImage.h: add bits from BaseTools version Gerd Hoffmann
2023-04-21 4:45 ` [PATCH v5 07/10] BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks Gerd Hoffmann
2023-04-21 4:45 ` [PATCH v5 08/10] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_* Gerd Hoffmann
2023-04-21 4:45 ` [PATCH v5 09/10] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h Gerd Hoffmann
2023-04-21 4:45 ` [PATCH v5 10/10] BaseTools: remove duplicate includes: IndustryStandard/*.h Gerd Hoffmann
2023-05-04 10:11 ` [PATCH v5 00/10] BaseTools: remove duplicate includes Gerd Hoffmann
2023-05-04 12:38 ` 回复: " gaoliming
2023-05-04 12:40 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yoxfsdhq23nsdtw22w3znxdoklxsy3z4c4zmqvnnpebgfllnyw@5mmdw5dnooti \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox