From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.25245.1683612521990556467
 for <devel@edk2.groups.io>;
 Mon, 08 May 2023 23:08:42 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IZz46kI3;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1683612520;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=gfTFGWfKZ+5aO/2GTcgYX2ZCo0RCsBDpCYCEVnM7zOM=;
	b=IZz46kI3Ks0ZFaeMkx6mbpHtiLOEzaOCqNlSk0fjoLEgQSp/sj+Fx90NFWF+hkKYrGfHf+
	dRu4BIa+3O9k3j3p2VaUrV+2qgBuwZQU2OsD86kQHa9EFpXJxMh2GGOXNe4FAAg1vfkHj4
	DmVDgHtpO7nCr9UdSbQHPGsDJYVfcA4=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-365-roXctPlXO_iYPCPy5_RuYA-1; Tue, 09 May 2023 02:08:33 -0400
X-MC-Unique: roXctPlXO_iYPCPy5_RuYA-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4245868A01;
	Tue,  9 May 2023 06:08:29 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.221])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 19B02C15BA0;
	Tue,  9 May 2023 06:08:26 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 9EA821801081; Tue,  9 May 2023 08:08:24 +0200 (CEST)
Date: Tue, 9 May 2023 08:08:24 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: Marvin =?utf-8?Q?H=C3=A4user?= <mhaeuser@posteo.de>, 
	Ard Biesheuvel <ardb@kernel.org>, devel@edk2.groups.io, Yuwei Chen <yuwei.chen@intel.com>, 
	Oliver Steffen <osteffen@redhat.com>, Bob Feng <bob.c.feng@intel.com>, 
	Daniel Schaefer <git@danielschaefer.me>, Chao Li <lichao@loongson.cn>, 
	Dongyan Qian <qiandongyan@loongson.cn>, Michael D Kinney <michael.d.kinney@intel.com>, 
	Pawel Polawski <ppolawsk@redhat.com>, Baoqi Zhang <zhangbaoqi@loongson.cn>, 
	Leif Lindholm <quic_llindhol@quicinc.com>, Zhiguang Liu <zhiguang.liu@intel.com>, 
	Sunil V L <sunilvl@ventanamicro.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH v5 02/10] MdePkg: don't set visibility to hidden
Message-ID: <yoxfsdhq23nsdtw22w3znxdoklxsy3z4c4zmqvnnpebgfllnyw@5mmdw5dnooti>
References: <CAMj1kXFKJbnVpUotFh2aihc+8Z_GM-WT90ZBm_UwzDgvWqcpnQ@mail.gmail.com>
 <B8F89389-EFD1-4960-AA32-462E7CC06784@posteo.de>
 <5faf3ba0-0d75-f526-6491-30c2c96ad186@bsdio.com>
MIME-Version: 1.0
In-Reply-To: <5faf3ba0-0d75-f526-6491-30c2c96ad186@bsdio.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 05, 2023 at 08:33:41AM -0600, Rebecca Cran wrote:
> Gerd,
> 
> 
> Does this series need rework following this discussion, or is it ready to
> merge?

I think we are good to go.  The ASSERT suggested by Ard here ...

> 
> > > So it would be better to ASSERT() on non-empty GOT, and ignore such
> > > GOTPCREL relocations instead of attempting to relocate the GOT entries
> > > they (used to) refer to.

... is added to the linker scripts by patch #1 of the series.

take care,
  Gerd