From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"László Érsek" <lersek@redhat.com>,
"Oliver Steffen" <osteffen@redhat.com>
Subject: Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable
Date: Thu, 25 Jan 2024 13:17:24 +0100 [thread overview]
Message-ID: <yr4cjvnzr4ljv32ctw37pw2sdrok4alxntfmxon7t6m3q7kdgf@eivnhofnu5fa> (raw)
In-Reply-To: <MN6PR11MB824498DF68A6F4865C8C432F8C7A2@MN6PR11MB8244.namprd11.prod.outlook.com>
On Thu, Jan 25, 2024 at 12:01:46PM +0000, Ni, Ray wrote:
> Rename an existing PCD might break lots of platform builds.
>
> When 5-level paging capability was added to ResetVector, I also
> considered to remove the PcdUse5LevelPageTable reference from C code.
>
> Let me think about it...
Purging this completely from the source code is fine with me too.
From OVMF point of view this is not needed, all backward compatibility
concerns for old guests without 5-level paging support can be solved by
just removing la57 capability from the vCPU (qemu -cpu host,la57=off).
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114398): https://edk2.groups.io/g/devel/message/114398
Mute This Topic: https://groups.io/mt/103950404/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-25 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 8:20 [edk2-devel] [PATCH v2 0/2] MdeModulePkg: 5-level paging fixes Gerd Hoffmann
2024-01-25 8:20 ` [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable Gerd Hoffmann
2024-01-25 12:01 ` Ni, Ray
2024-01-25 12:17 ` Gerd Hoffmann [this message]
2024-01-26 2:49 ` Zhiguang Liu
2024-01-26 13:19 ` Gerd Hoffmann
2024-01-25 8:20 ` [edk2-devel] [PATCH v2 2/2] MdeModulePkg/VirtualMemory: fix 5-level paging assert Gerd Hoffmann
2024-01-25 23:22 ` [edk2-devel] [PATCH v2 0/2] MdeModulePkg: 5-level paging fixes Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yr4cjvnzr4ljv32ctw37pw2sdrok4alxntfmxon7t6m3q7kdgf@eivnhofnu5fa \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox