public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: devel@edk2.groups.io, Pawel Polawski <ppolawsk@redhat.com>,
	 Anthony Perard <anthony.perard@citrix.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	 Jiewen Yao <jiewen.yao@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	 Julien Grall <julien@xen.org>,
	Oliver Steffen <osteffen@redhat.com>,
	 Jian J Wang <jian.j.wang@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	dannf@debian.org,  Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [PATCH v3 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*
Date: Thu, 30 Mar 2023 12:50:37 +0200	[thread overview]
Message-ID: <yrkvi5aq3s4uwkq6ss47al2f2ikqhorbsrj3gjt3qjek2my356@pcxclrgd4cy6> (raw)
In-Reply-To: <7a47bad8-5479-8a56-e41b-3fd6961d9673@proxmox.com>

On Thu, Mar 30, 2023 at 12:18:35PM +0200, Fiona Ebner wrote:
> Am 30.03.23 um 10:53 schrieb Gerd Hoffmann:
> > On Thu, Mar 30, 2023 at 10:04:02AM +0200, Fiona Ebner wrote:
> >> Am 28.11.22 um 06:40 schrieb Gerd Hoffmann:
> >> Hi,
> >> after this patch, certain SMBIOS values are different[2]. We got a
> >> report that the different vendor causes issues with hardware keys[0].
> >> And, as I learned from the patch fixing it, the missing date can cause
> >> issues with Windows[1].
> > 
> > See a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release
> > date") for the windows issue.
> > 
> 
> Should the date string be "02/02/2022" rather than "2/2/2022" in that
> commit?

Windows tests pass with "2/2/2022", but I have to admit didn't check the
specs.

take care,
  Gerd


      reply	other threads:[~2023-03-30 10:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28  5:40 [PATCH v3 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmware* Gerd Hoffmann
2022-12-09 14:15 ` Yao, Jiewen
     [not found] ` <172F259BA3D70E83.5373@groups.io>
2022-12-11  3:09   ` [edk2-devel] " Yao, Jiewen
2023-03-30  8:04 ` Fiona Ebner
2023-03-30  8:53   ` Gerd Hoffmann
2023-03-30 10:18     ` Fiona Ebner
2023-03-30 10:50       ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yrkvi5aq3s4uwkq6ss47al2f2ikqhorbsrj3gjt3qjek2my356@pcxclrgd4cy6 \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox