From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.21996.1680173452753287673
 for <devel@edk2.groups.io>;
 Thu, 30 Mar 2023 03:50:53 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HzrgWNeL;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1680173451;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9Bhpi8BedADvaRdLdq8Kl5ykTBb5/tmN0V0pkJLyL7U=;
	b=HzrgWNeLN0DztZz8CawIrZzGtHXAMLDQ4fvPP/4F+NfVjmMuH5NnTgC+VUYUpbIQu/3MTv
	IMtj7QuJSOrPQtH5FJ2Qm59zG64kkAWU3dTktncc73HDZfXSq7pHFvIb5ilK/p6oqcFkW0
	DTzNZa2e8jYx/fO0y9Ke5JNyYBOkozI=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-591-JUY9FsSzPhCeznzr0lYwFg-1; Thu, 30 Mar 2023 06:50:41 -0400
X-MC-Unique: JUY9FsSzPhCeznzr0lYwFg-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7767B1C05143;
	Thu, 30 Mar 2023 10:50:40 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.49])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 312B42166B33;
	Thu, 30 Mar 2023 10:50:40 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id A7DB41800DC3; Thu, 30 Mar 2023 12:50:37 +0200 (CEST)
Date: Thu, 30 Mar 2023 12:50:37 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: devel@edk2.groups.io, Pawel Polawski <ppolawsk@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, Jordan Justen <jordan.l.justen@intel.com>, 
	Jiewen Yao <jiewen.yao@intel.com>, Liming Gao <gaoliming@byosoft.com.cn>, 
	Julien Grall <julien@xen.org>, Oliver Steffen <osteffen@redhat.com>, 
	Jian J Wang <jian.j.wang@intel.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, dannf@debian.org, 
	Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [PATCH v3 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*
Message-ID: <yrkvi5aq3s4uwkq6ss47al2f2ikqhorbsrj3gjt3qjek2my356@pcxclrgd4cy6>
References: <20221128054020.25531-1-kraxel@redhat.com>
 <a6656913-a09a-82d2-14f0-528b1f8fc791@proxmox.com>
 <njs3vlxl3frhp3enklmteo6knltwxulg6it44llygiyy3ibutl@5usndno4uh7e>
 <7a47bad8-5479-8a56-e41b-3fd6961d9673@proxmox.com>
MIME-Version: 1.0
In-Reply-To: <7a47bad8-5479-8a56-e41b-3fd6961d9673@proxmox.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 30, 2023 at 12:18:35PM +0200, Fiona Ebner wrote:
> Am 30.03.23 um 10:53 schrieb Gerd Hoffmann:
> > On Thu, Mar 30, 2023 at 10:04:02AM +0200, Fiona Ebner wrote:
> >> Am 28.11.22 um 06:40 schrieb Gerd Hoffmann:
> >> Hi,
> >> after this patch, certain SMBIOS values are different[2]. We got a
> >> report that the different vendor causes issues with hardware keys[0].
> >> And, as I learned from the patch fixing it, the missing date can cause
> >> issues with Windows[1].
> > 
> > See a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release
> > date") for the windows issue.
> > 
> 
> Should the date string be "02/02/2022" rather than "2/2/2022" in that
> commit?

Windows tests pass with "2/2/2022", but I have to admit didn't check the
specs.

take care,
  Gerd