Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

["Gerd Hoffmann" <kraxel@redhat.com>]

On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote:
> On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > >
> > >   Hi,
> > >
> > > > I have tried the patch below, and I don't see any slowdowns with or
> > > > without the patch, running both DEBUG and RELEASE builds under
> > > > ordinary KVM/nested-virt. Note that the change in the first hunk will
> > > > cause the ASSERT()s removed in the other hunks to trigger so the code
> > > > is definitely being exercised.
> > >
> > > QE team tested again with fresh builds, the slowdown isn't there any
> > > more.  Not fully clear where it came from, but most likely not from
> > > this patch.
> > >
> > > Only 20 successful test runs so far, which a good start, but with
> > > a reproduce rate below 20% not that much.    I'll post an update
> > > when it I get more results.
> > >
> >
> > Excellent, thanks for the update.
> 
> Given that the QE engineer appears to have lost interest, I intend to
> merge this patch as-is unless anyone feels this is premature.

I was offline a few days.  QE actually reported back: 100 test runs
without problems.

Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108256): https://edk2.groups.io/g/devel/message/108256
Mute This Topic: https://groups.io/mt/100256049/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-