From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E1072D80D4E for ; Mon, 4 Sep 2023 11:45:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LzFSEDdkdlr0IB++uWq2jhLCe4gE07aKgPEzyaK4Oe8=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1693827941; v=1; b=CorHq9XuC7vLgbiyZsQJyO1fJ2Wu4ZhZLRU80H+55fMVEwlFpmRVBzSrU5ATsGTRE8YrO2ZX zz2CVD/s9AYr2NEFhEWk4JKlGvz60glsCylO2k1TsqIHahxnTGelNhNIR/+cFrIR4xeEXCGh7eH VvoSdJMozUtdUMSjFR+IvbJw= X-Received: by 127.0.0.2 with SMTP id Pyk3YY7687511xGroPHLF4kx; Mon, 04 Sep 2023 04:45:41 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.45808.1693827940789035710 for ; Mon, 04 Sep 2023 04:45:41 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-678-WHGOmqVZP1CnQt9GZEp_dQ-1; Mon, 04 Sep 2023 07:45:36 -0400 X-MC-Unique: WHGOmqVZP1CnQt9GZEp_dQ-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 74BF63803505; Mon, 4 Sep 2023 11:45:31 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CB74140E963; Mon, 4 Sep 2023 11:45:31 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E0A8D18007A8; Mon, 4 Sep 2023 13:45:29 +0200 (CEST) Date: Mon, 4 Sep 2023 13:45:29 +0200 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Pedro Falcato , Jiewen Yao , Michael Brown , Tom Lendacky , Michael Roth Subject: Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy Message-ID: References: <4bd53ehby2cto5n2venjfkucot5ayj2xtsl7z6diegh6llrpm2@tj5oh6txxjck> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8uXJhVcnMOR2oTGIThglaDH4x7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CorHq9Xu; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote: > On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote: > > > > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > I have tried the patch below, and I don't see any slowdowns with or > > > > without the patch, running both DEBUG and RELEASE builds under > > > > ordinary KVM/nested-virt. Note that the change in the first hunk will > > > > cause the ASSERT()s removed in the other hunks to trigger so the code > > > > is definitely being exercised. > > > > > > QE team tested again with fresh builds, the slowdown isn't there any > > > more. Not fully clear where it came from, but most likely not from > > > this patch. > > > > > > Only 20 successful test runs so far, which a good start, but with > > > a reproduce rate below 20% not that much. I'll post an update > > > when it I get more results. > > > > > > > Excellent, thanks for the update. > > Given that the QE engineer appears to have lost interest, I intend to > merge this patch as-is unless anyone feels this is premature. I was offline a few days. QE actually reported back: 100 test runs without problems. Tested-by: Gerd Hoffmann Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108256): https://edk2.groups.io/g/devel/message/108256 Mute This Topic: https://groups.io/mt/100256049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-