From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id CA9587803D1 for ; Tue, 16 Apr 2024 07:31:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=f4esuNTkopcbGVS8i9eF86us5Hx4UOdsSNws6Bo7DYs=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1713252684; v=1; b=D55OkPPa1wU+DUmEu/Hmf2qmrpnlTQh6IbxiqqJjDyT/0WFvhhPIZlldNSF+uqQbvMBCs0or kd50obHxBMfP1gWkK3ckK3MAc2vjut5ABVPBmvySIzZmWthrdhlzNIEO1EIBc7qB2C48oQheBHa X7WRVTQj6BXqmQ4rbH33zX7X+xBlflSvpx3pF1rpNItSQdFUXUbQHCoZ6CDJFcb/NP8AHOJxxhQ tg06nc+WNUIkz90qHBAjkZpvJR+Mpf5bDUOxA3DSyMQgTUrPQnaqVLUDTco3+UVR7NBFC9s0v+b XAYFfVN4yA5eE3EeUk5cXlb9ujwRndvTgENFMDIQvxJuQ== X-Received: by 127.0.0.2 with SMTP id xD1KYY7687511x9szR5LITBL; Tue, 16 Apr 2024 00:31:24 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.14674.1713252683564080520 for ; Tue, 16 Apr 2024 00:31:23 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-lLCxVQZfPIS-NB4rt5Jxpg-1; Tue, 16 Apr 2024 03:31:18 -0400 X-MC-Unique: lLCxVQZfPIS-NB4rt5Jxpg-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 15307801787; Tue, 16 Apr 2024 07:31:18 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.169]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99B202026D06; Tue, 16 Apr 2024 07:31:17 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 92FDA18009E6; Tue, 16 Apr 2024 09:31:12 +0200 (CEST) Date: Tue, 16 Apr 2024 09:31:12 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, jiaxin.wu@intel.com Cc: Ray Ni , Zeng Star , Rahul Kumar , Guo Dong , Sean Rhodes , James Lu , Gua Guo , Ard Biesheuvel , Jiewen Yao , Abdul Lateef Attar , Abner Chang , Tom Lendacky Subject: Re: [edk2-devel] [PATCH v2 00/10] Add SmmRelocationLib Message-ID: References: <20240415133021.10516-1-jiaxin.wu@intel.com> MIME-Version: 1.0 In-Reply-To: <20240415133021.10516-1-jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 16 Apr 2024 00:31:23 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XzCV5nPO1mE799BTOmtBlD0mx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=D55OkPPa; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Apr 15, 2024 at 09:30:11PM +0800, Wu, Jiaxin wrote: > Intel plans to separate the smbase relocation logic from > PiSmmCpuDxeSmm driver, and the related behavior will be > moved to the new interface defined by the SmmRelocationLib > class. > > The SmmRelocationLib class provides the SmmRelocationInit() > interface for platform to do the smbase relocation, which > shall provide below 2 functionalities: > 1. Relocate smbases for each processor. > 2. Create the gSmmBaseHobGuid HOB. > > With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at > a later phase) can be simplfied as below for SMM init: > 1. Consume the gSmmBaseHobGuid HOB for the relocated smbases > for each Processor. > 2. Execute the early SMM Init. How this was tested? I can't even build this (without -D SMM_REQUIRE=TRUE). /home/kraxel/projects/edk2/OvmfPkg/OvmfPkgX64.dsc(...): error 4000: Instance of library class [SmmRelocationLib] is not found in [/home/kraxel/projects/edk2/OvmfPkg/PlatformPei/PlatformPei.inf] [X64] consumed by module [/home/kraxel/projects/edk2/OvmfPkg/PlatformPei/PlatformPei.inf] I doubt it passes CI. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117852): https://edk2.groups.io/g/devel/message/117852 Mute This Topic: https://groups.io/mt/105535804/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-