From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.5912.1682059777912686686
 for <devel@edk2.groups.io>;
 Thu, 20 Apr 2023 23:49:38 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dMjfyjen;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1682059776;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=g6JJU72DR8K8ZPGjl5ZA+DRgiyY0vH2VOlFSdQp6UMQ=;
	b=dMjfyjeniaBxKy1bvkgXzIaduxI70/ZN4cvVCi2QPoKK9Jm1gjmSrRbvu5U6fChhqtCEvY
	HMc0RvYmf9DkPGutt8abnXeE+RDXpvSZ5R8jLtzRYFlCaxmFCMT8nkv75chz9xtmPHMGsx
	meTQmK0vLQ/aH+KtNae+NFgISgqwmDw=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-564-m0SvI_y4OzuTUXeDjZdNoQ-1; Fri, 21 Apr 2023 02:49:32 -0400
X-MC-Unique: m0SvI_y4OzuTUXeDjZdNoQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A85FA87A9E3;
	Fri, 21 Apr 2023 06:49:31 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.59])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 222C1140EBF4;
	Fri, 21 Apr 2023 06:49:29 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 497B11800083; Fri, 21 Apr 2023 08:49:27 +0200 (CEST)
Date: Fri, 21 Apr 2023 08:49:27 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Marvin =?utf-8?Q?H=C3=A4user?= <mhaeuser@posteo.de>
Cc: devel@edk2.groups.io, Yuwei Chen <yuwei.chen@intel.com>, 
	Oliver Steffen <osteffen@redhat.com>, Bob Feng <bob.c.feng@intel.com>, 
	Daniel Schaefer <git@danielschaefer.me>, Chao Li <lichao@loongson.cn>, 
	Dongyan Qian <qiandongyan@loongson.cn>, Michael D Kinney <michael.d.kinney@intel.com>, 
	Pawel Polawski <ppolawsk@redhat.com>, Baoqi Zhang <zhangbaoqi@loongson.cn>, 
	Leif Lindholm <quic_llindhol@quicinc.com>, Rebecca Cran <rebecca@bsdio.com>, 
	Zhiguang Liu <zhiguang.liu@intel.com>, Sunil V L <sunilvl@ventanamicro.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH v5 02/10] MdePkg: don't set visibility to hidden
Message-ID: <zd6ghzbnlau3gjmmm6fmjrwhrpok42hw374r6j66hofbkxqqoc@6w6nbdejngyy>
References: <20230421044535.4030762-3-kraxel@redhat.com>
 <A520C426-43A2-445D-9CF4-F20C37C87024@posteo.de>
MIME-Version: 1.0
In-Reply-To: <A520C426-43A2-445D-9CF4-F20C37C87024@posteo.de>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Fri, Apr 21, 2023 at 06:01:11AM +0000, Marvin Häuser wrote:
> 
> > On 21. Apr 2023, at 06:45, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > 
> > Not needed any more on modern toolchains, they are better
> > in not creating a GOT without this trick.
> 
> Hi Gerd,
> 
> Thanks! Just out of interest, how did you test this and what were the results?

Patch #1, adding a linker script assert as suggested by ard, then:

 * compile + test on my local workstation (fedora 37, gcc 12).
 * run CI
 * compile on some older distros:
   - rhel-8 (gcc 8)
   - ubuntu-18.04 (gcc 7)

take care,
  Gerd