Re: [edk2-devel] [PATCH v1 18/26] OvmfPkg/LoongArchVirt: Add the early serial port output library

["Gerd Hoffmann" <kraxel@redhat.com>]

On Fri, Mar 15, 2024 at 06:19:12PM +0800, Chao Li wrote:
> Hi Gerd,
> 
> 
> Thanks,
> Chao
> On 2024/3/15 17:36, Gerd Hoffmann wrote:
> > On Mon, Mar 11, 2024 at 05:39:08PM +0800, Chao Li wrote:
> > > Add a early serial port output library into LoongArchVirt that named
> > > EarlyFdtSerialPortLib16550, this library is referenced from
> > > MdeModulePkg.
> > Why create your own copy?  What are the differences to
> > MdeModulePkg/Library/BaseSerialPortLib16550?
> This library is used in the PEI stage, same as the Hook Library, LoongArch
> QEMU is runs on flash in PEI stage, MdeModule version does not support to
> get the SerialRegisterBase via registers or HOB or FDT,

It uses PcdSerialRegisterBase.

Having a quick look at the PCD code it looks like the PCD are stored in
in a HOB (gPcdDataBaseHobGuid), so setting dynamic PCDs should work even
when running directly from flash.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116807): https://edk2.groups.io/g/devel/message/116807
Mute This Topic: https://groups.io/mt/104859894/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-