From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C98579411AF for ; Fri, 15 Mar 2024 10:34:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AeKNEYr8HvEEj1FqGrdqTfg3PvmSrcHUR4MqlCcB1ck=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1710498853; v=1; b=rCWjsSG9Ylrybyv4gpWXwo7hLzWk2SuClDQ1+wDzbjsIkBIbfADlR4pFC64ulYokwLjbqSy1 qzQ6AvJbEeELlelvYh09BeUqhMWwuAyejUINm4gA7cko+qjuvTyezgXDftoPNOiOGCSYh2Wn89n UWJMrFVMV1JyY06B+4KFyT4Iod2HXoeV7/dYO63UTTMfl7ePJbp3UOmJ1Q6O8evY2qTyfw/MN+J 7N2V24ZCfGOSm9eZz8nvjDq/p5wA45Ay9jxUxCPDJ81x+Pr5QMuul/MLByviVGwqFzbo0svhSxS AcBHwF2y3SzmfZ0UdyLUmAXyKam/HGlzSm5h2xIb/58TA== X-Received: by 127.0.0.2 with SMTP id FUoLYY7687511xVtmGj7R52U; Fri, 15 Mar 2024 03:34:13 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.18806.1710498852813570712 for ; Fri, 15 Mar 2024 03:34:12 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-HLZNpYPSOCavmAEwPEHRkA-1; Fri, 15 Mar 2024 06:34:08 -0400 X-MC-Unique: HLZNpYPSOCavmAEwPEHRkA-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B59BA2800B30; Fri, 15 Mar 2024 10:34:07 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D8333C21; Fri, 15 Mar 2024 10:34:07 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 461D01800DD4; Fri, 15 Mar 2024 11:34:06 +0100 (CET) Date: Fri, 15 Mar 2024 11:34:06 +0100 From: "Gerd Hoffmann" To: Chao Li Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian , Xianglai Li Subject: Re: [edk2-devel] [PATCH v1 18/26] OvmfPkg/LoongArchVirt: Add the early serial port output library Message-ID: References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093908.1254385-1-lichao@loongson.cn> <32d4cd2c-1d83-48f5-ba30-7eda6dbcbf44@loongson.cn> MIME-Version: 1.0 In-Reply-To: <32d4cd2c-1d83-48f5-ba30-7eda6dbcbf44@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 15 Mar 2024 03:34:13 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ARfNVhS8VkR0lXQb7UGpVYSnx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rCWjsSG9; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Mar 15, 2024 at 06:19:12PM +0800, Chao Li wrote: > Hi Gerd, > > > Thanks, > Chao > On 2024/3/15 17:36, Gerd Hoffmann wrote: > > On Mon, Mar 11, 2024 at 05:39:08PM +0800, Chao Li wrote: > > > Add a early serial port output library into LoongArchVirt that named > > > EarlyFdtSerialPortLib16550, this library is referenced from > > > MdeModulePkg. > > Why create your own copy? What are the differences to > > MdeModulePkg/Library/BaseSerialPortLib16550? > This library is used in the PEI stage, same as the Hook Library, LoongArch > QEMU is runs on flash in PEI stage, MdeModule version does not support to > get the SerialRegisterBase via registers or HOB or FDT, It uses PcdSerialRegisterBase. Having a quick look at the PCD code it looks like the PCD are stored in in a HOB (gPcdDataBaseHobGuid), so setting dynamic PCDs should work even when running directly from flash. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116807): https://edk2.groups.io/g/devel/message/116807 Mute This Topic: https://groups.io/mt/104859894/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-