From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
Ray Ni <ray.ni@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes
Date: Tue, 7 Nov 2023 10:55:25 +0100 [thread overview]
Message-ID: <zyt7p4dwtbodbt5elq7rohat2by5jnuisfag6bgasyeliiww7t@ksoek6euidzy> (raw)
In-Reply-To: <cover.1699310731.git.thomas.lendacky@amd.com>
On Mon, Nov 06, 2023 at 04:45:29PM -0600, Tom Lendacky wrote:
> This patch series provides fixes around AP startup and sorting:
>
> - The CPUID_EXTENDED_TOPOLOGY CPUID leaf takes a sub-leaf as input. The
> current SEV-SNP support is attempting to retrieve the this leaf with
> sub-leaf 0, but is calling AsmCpuid(), which does not clear ECX before
> invoking the CPUID instruction. Therefore, because of the calling
> convention, the leaf value becomes the sub-leaf value and ends up
> returning incorrect information. Change the call from AsmCpuid() to
> AsmCpuidEx().
>
> - When sorting the CPUs by APIC ID, the VMSA associated with the vCPU
> should follow the APIC ID. Update the sorting code to swap the VMSA
> pointer during the sort.
Series:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110831): https://edk2.groups.io/g/devel/message/110831
Mute This Topic: https://groups.io/mt/102432041/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-07 9:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 22:45 [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes Lendacky, Thomas via groups.io
2023-11-06 22:45 ` [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf Lendacky, Thomas via groups.io
2023-11-28 10:31 ` Ni, Ray
2023-11-06 22:45 ` [edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Copy SEV-ES save area pointer during APIC ID sorting Lendacky, Thomas via groups.io
2023-11-28 10:33 ` Ni, Ray
[not found] ` <17952A20A9E21541.12603@groups.io>
2023-11-06 23:15 ` [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf Lendacky, Thomas via groups.io
2023-11-07 1:19 ` Michael D Kinney
2023-11-28 14:35 ` Lendacky, Thomas via groups.io
[not found] ` <179BD02AA4207037.22216@groups.io>
2024-01-17 21:26 ` Lendacky, Thomas via groups.io
2024-01-18 23:10 ` Michael D Kinney
2024-01-19 10:00 ` Ni, Ray
2024-01-19 23:16 ` Michael D Kinney
2024-01-19 23:48 ` Ni, Ray
2024-01-20 1:49 ` Michael D Kinney
2024-01-20 6:48 ` Ni, Ray
2024-01-20 16:03 ` Lendacky, Thomas via groups.io
2024-01-21 3:00 ` Ni, Ray
2023-11-07 9:55 ` Gerd Hoffmann [this message]
2023-11-17 21:43 ` [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes Lendacky, Thomas via groups.io
2023-11-27 19:00 ` Lendacky, Thomas via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=zyt7p4dwtbodbt5elq7rohat2by5jnuisfag6bgasyeliiww7t@ksoek6euidzy \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox