From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 73691AC10A5 for ; Tue, 7 Nov 2023 09:55:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KLaOlDaTetYVEURIm2A712Myy/7JnRv29SXOsqdpth4=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1699350935; v=1; b=H3IEtakAPAtdMITJ8c5q8glsZcg8IqZh7jZXSZIeAsSKtm3f2kf9a5WJOfJiWKE6gKADovD6 UZxTJpXEPUuuu0j0XWxd4itiRH3WROxC0fn0/H9AlDdLeb+PswTu9RoK5CbhWZT+ejbhsJ2OSgP WD99eOXKunyPQ8yWBYuZOKhg= X-Received: by 127.0.0.2 with SMTP id Zk53YY7687511xmuerqqrKhr; Tue, 07 Nov 2023 01:55:35 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.6821.1699350934157801418 for ; Tue, 07 Nov 2023 01:55:34 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-luPO6RImNdSakPIAxMsWxA-1; Tue, 07 Nov 2023 04:55:28 -0500 X-MC-Unique: luPO6RImNdSakPIAxMsWxA-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B5D4810FD2; Tue, 7 Nov 2023 09:55:27 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.119]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D641492BFA; Tue, 7 Nov 2023 09:55:27 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E7F441800DDB; Tue, 7 Nov 2023 10:55:25 +0100 (CET) Date: Tue, 7 Nov 2023 10:55:25 +0100 From: "Gerd Hoffmann" To: Tom Lendacky Cc: devel@edk2.groups.io, Eric Dong , Ray Ni , Rahul Kumar , Ard Biesheuvel , Michael Roth Subject: Re: [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Cio8D2mMwsRcNVpZmrpPW0Ijx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=H3IEtakA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Nov 06, 2023 at 04:45:29PM -0600, Tom Lendacky wrote: > This patch series provides fixes around AP startup and sorting: > > - The CPUID_EXTENDED_TOPOLOGY CPUID leaf takes a sub-leaf as input. The > current SEV-SNP support is attempting to retrieve the this leaf with > sub-leaf 0, but is calling AsmCpuid(), which does not clear ECX before > invoking the CPUID instruction. Therefore, because of the calling > convention, the leaf value becomes the sub-leaf value and ends up > returning incorrect information. Change the call from AsmCpuid() to > AsmCpuidEx(). > > - When sorting the CPUs by APIC ID, the VMSA associated with the vCPU > should follow the APIC ID. Update the sorting code to swap the VMSA > pointer during the sort. Series: Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110831): https://edk2.groups.io/g/devel/message/110831 Mute This Topic: https://groups.io/mt/102432041/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-