From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, Rebecca Cran <rebecca@bsdio.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH] BaseTools/tools_def: Disable overzealous unused variable warning on Clang
Date: Thu, 11 May 2023 06:55:11 +0200 [thread overview]
Message-ID: <zyufdouq6zxotddwnyr74a7yb255pfbqol4gfdcz2zwneziyau@bjybdz43enva> (raw)
In-Reply-To: <20230510145008.1893553-1-ardb@kernel.org>
On Wed, May 10, 2023 at 04:50:08PM +0200, Ard Biesheuvel wrote:
> The warnings Clang emits when enabling -Wunneeded-internal-declaration
> (which is part of -Wall) are generating false positives for variables
> whose size gets taken but are not referenced beyond that.
>
> This may happen legitimately in debug code, so let's disable this
> warning for Clang, rather than tiptoe around it in the code base.
>
> This fixes the RELEASE build for OVMF, which triggers this issue in the
> newly added VirtioSerialDxe driver.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
next prev parent reply other threads:[~2023-05-11 4:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 14:50 [PATCH] BaseTools/tools_def: Disable overzealous unused variable warning on Clang Ard Biesheuvel
2023-05-10 14:54 ` Rebecca Cran
2023-05-11 4:55 ` Gerd Hoffmann [this message]
2023-05-12 6:39 ` [edk2-devel] " Ard Biesheuvel
2023-05-15 0:55 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=zyufdouq6zxotddwnyr74a7yb255pfbqol4gfdcz2zwneziyau@bjybdz43enva \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox