Re: [edk2-devel] [PATCH v3 1/3] ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c

["Stuart Yoder" <stuart.yoder@arm.com>]

Hi Sam,

See comments below...

> +SHELL_STATUS
> +DisplayRtProperties (
> +  IN UINT64 Address
> +  )
> +{
> +  EFI_RT_PROPERTIES_TABLE *RtPropertiesTable;
> +  UINT32                  RtServices;
> +  SHELL_STATUS            ShellStatus;
> +  EFI_STATUS              Status;
> +
> +  ShellStatus = SHELL_SUCCESS;
> +
> +  RtPropertiesTable = (EFI_RT_PROPERTIES_TABLE *)Address;
> +
> +  RtServices = (UINT32)RtPropertiesTable->RuntimeServicesSupported;

You are using the Address variable here without checking if it is
NULL or not.  Add a check like the other verbose functions in the
patch series.


> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
> index 4041f0cd483e..299b0ba44f31 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni

One things I see missing is that you don't have the help message for
the Dmem command updated to include the new -verbose option.  Update
the help message in UefiShellDebug1CommandsLib.uni in patch 1 of the
series.

Thanks,
Stuart


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117298): https://edk2.groups.io/g/devel/message/117298
Mute This Topic: https://groups.io/mt/105264289/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-