[edk2-devel] [ edk2-platforms: [PATCH] MinPlatformPkg: Add missed call to FreePool v2] MinPlatformPkg: Add missed call to FreePool

[edk2-devel] [ edk2-platforms: [PATCH] MinPlatformPkg: Add missed call to FreePool v2] MinPlatformPkg: Add missed call to FreePool

[phanindrax.babu.pabba]

From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>

Adding missed out call to FreePool API to free the
allocated memory.

Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 5 +++--
 Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c         | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 2a833ec9..9a91d131 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -975,7 +975,7 @@ InstallMcfgFromScratch (
              FixedPcdGet32 (PcdAcpiDefaultOemRevision)
              );
   if (EFI_ERROR (Status)) {
-    return Status;
+    goto Done;
   }
 
   //
@@ -1002,7 +1002,8 @@ InstallMcfgFromScratch (
                          McfgTable->Header.Length,
                          &TableHandle
                          );
-
+Done:
+  FreePool (McfgTable);
   return Status;
 }
 
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
index 9bc22245..f5b1a71c 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
@@ -195,6 +195,7 @@ PublishAcpiTablesFromFv (
       // Increment the instance
       //
       Instance++;
+      FreePool (CurrentTable);
       CurrentTable = NULL;
     }
   }
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117182): https://edk2.groups.io/g/devel/message/117182
Mute This Topic: https://groups.io/mt/105187779/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-