* [edk2-devel] [PATCH] MinPlatformPkg: Add missed call to FreePool
@ 2024-03-27 19:10 phanindrax.babu.pabba
0 siblings, 0 replies; 3+ messages in thread
From: phanindrax.babu.pabba @ 2024-03-27 19:10 UTC (permalink / raw)
To: devel
Cc: PhanindraX Babu Pabba, Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong
From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
Adding missed out call to FreePool API to free
the allocated memory.
Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 +-
Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 2a833ec9..f637e1c9 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1002,7 +1002,7 @@ InstallMcfgFromScratch (
McfgTable->Header.Length,
&TableHandle
);
-
+ FreePool (McfgTable);
return Status;
}
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
index 9bc22245..f5b1a71c 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
@@ -195,6 +195,7 @@ PublishAcpiTablesFromFv (
// Increment the instance
//
Instance++;
+ FreePool (CurrentTable);
CurrentTable = NULL;
}
}
--
2.39.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117180): https://edk2.groups.io/g/devel/message/117180
Mute This Topic: https://groups.io/mt/104524859/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 3+ messages in thread* [edk2-devel] [PATCH] MinPlatformPkg: Add missed call to FreePool
@ 2024-02-23 6:01 phanindrax.babu.pabba
2024-03-25 22:36 ` Nate DeSimone
0 siblings, 1 reply; 3+ messages in thread
From: phanindrax.babu.pabba @ 2024-02-23 6:01 UTC (permalink / raw)
To: devel
Cc: PhanindraX Babu Pabba, Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong
From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
Adding missed out call to FreePool API to free the
allocated memory.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 +-
Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 2a833ec9..f637e1c9 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1002,7 +1002,7 @@ InstallMcfgFromScratch (
McfgTable->Header.Length,
&TableHandle
);
-
+ FreePool (McfgTable);
return Status;
}
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
index 9bc22245..f5b1a71c 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
@@ -195,6 +195,7 @@ PublishAcpiTablesFromFv (
// Increment the instance
//
Instance++;
+ FreePool (CurrentTable);
CurrentTable = NULL;
}
}
--
2.39.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115875): https://edk2.groups.io/g/devel/message/115875
Mute This Topic: https://groups.io/mt/104524859/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH] MinPlatformPkg: Add missed call to FreePool
2024-02-23 6:01 phanindrax.babu.pabba
@ 2024-03-25 22:36 ` Nate DeSimone
0 siblings, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2024-03-25 22:36 UTC (permalink / raw)
To: Pabba, PhanindraX Babu, devel; +Cc: Chiu, Chasel, Liming Gao, Dong, Eric
Hi Babu,
If the call to InitializeHeader() fails then the buffer will still not be de-allcoated properly. Please add a Done: label and a goto Done; so that the buffer will still be freed in the case of an error.
Thanks,
Nate
-----Original Message-----
From: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>
Sent: Thursday, February 22, 2024 10:01 PM
To: devel@edk2.groups.io
Cc: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [PATCH] MinPlatformPkg: Add missed call to FreePool
From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
Adding missed out call to FreePool API to free the allocated memory.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 +-
Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 2a833ec9..f637e1c9 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1002,7 +1002,7 @@ InstallMcfgFromScratch (
McfgTable->Header.Length, &TableHandle );-+ FreePool (McfgTable); return Status; } diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
index 9bc22245..f5b1a71c 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
@@ -195,6 +195,7 @@ PublishAcpiTablesFromFv (
// Increment the instance // Instance++;+ FreePool (CurrentTable); CurrentTable = NULL; } }--
2.39.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117095): https://edk2.groups.io/g/devel/message/117095
Mute This Topic: https://groups.io/mt/104524859/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-27 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-27 19:10 [edk2-devel] [PATCH] MinPlatformPkg: Add missed call to FreePool phanindrax.babu.pabba
-- strict thread matches above, loose matches on Subject: below --
2024-02-23 6:01 phanindrax.babu.pabba
2024-03-25 22:36 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox