* [edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types
@ 2023-11-15 12:46 Marcin Juszkiewicz
2023-11-15 13:05 ` Leif Lindholm
2023-11-22 15:14 ` Leif Lindholm
0 siblings, 2 replies; 3+ messages in thread
From: Marcin Juszkiewicz @ 2023-11-15 12:46 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Graeme Gregory, Jeremy Linton, Leif Lindholm,
Ling Jia, Marcin Wojtas, Peng Xie, Yiqi Shu, Marcin Juszkiewicz
acpiview complains:
ERROR: On Arm based systems, all cache properties must be provided in
the cache type structure. Missing 'Write Policy Valid' flag.
ACPI specification says:
> Set to 1 if the write policy attribute described is valid. A value
> of 0 indicates that, where possible, processor architecture specific
> discovery mechanisms should be used to ascertain the value of this
> attribute.
Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 2 +-
Platform/RaspberryPi/AcpiTables/Pptt.aslc | 2 +-
Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc | 2 +-
Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc | 2 +-
Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc | 2 +-
Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
index 983d17f6fa50..61d8bce8c959 100644
--- a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
+++ b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
@@ -126,7 +126,7 @@ typedef struct {
1, /* AssociativityValid */ \
1, /* AllocationTypeValid */ \
1, /* CacheTypeValid */ \
- 0, /* WritePolicyValid */ \
+ 1, /* WritePolicyValid */ \
1, /* LineSizeValid */ \
}, \
0, /* NextLevelOfCache */ \
diff --git a/Platform/RaspberryPi/AcpiTables/Pptt.aslc b/Platform/RaspberryPi/AcpiTables/Pptt.aslc
index a52bc5a31adf..b80f5ff1e057 100644
--- a/Platform/RaspberryPi/AcpiTables/Pptt.aslc
+++ b/Platform/RaspberryPi/AcpiTables/Pptt.aslc
@@ -114,7 +114,7 @@ typedef struct {
1, /* AssociativityValid */ \
1, /* AllocationTypeValid */ \
1, /* CacheTypeValid */ \
- 0, /* WritePolicyValid */ \
+ 1, /* WritePolicyValid */ \
1, /* LineSizeValid */ \
}, \
0, /* NextLevelOfCache */ \
diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc b/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
index e03bfcd6211d..f3a9b90fb564 100644
--- a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
+++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
@@ -94,7 +94,7 @@ typedef struct {
1, /* AssociativityValid */ \
1, /* AllocationTypeValid */ \
1, /* CacheTypeValid */ \
- 0, /* WritePolicyValid */ \
+ 1, /* WritePolicyValid */ \
1, /* LineSizeValid */ \
}, \
0, /* NextLevelOfCache */ \
diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
index f37c7511134d..3793cbbca0b5 100644
--- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
+++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
@@ -94,7 +94,7 @@ typedef struct {
1, /* AssociativityValid */ \
1, /* AllocationTypeValid */ \
1, /* CacheTypeValid */ \
- 0, /* WritePolicyValid */ \
+ 1, /* WritePolicyValid */ \
1, /* LineSizeValid */ \
}, \
0, /* NextLevelOfCache */ \
diff --git a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
index ae1a21df23b9..04652653563e 100644
--- a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
+++ b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
@@ -92,7 +92,7 @@ typedef struct {
1, /* AssociativityValid */ \
1, /* AllocationTypeValid */ \
1, /* CacheTypeValid */ \
- 0, /* WritePolicyValid */ \
+ 1, /* WritePolicyValid */ \
1, /* LineSizeValid */ \
}, \
0, /* NextLevelOfCache */ \
diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
index e351d82b9763..f3e9149769ea 100644
--- a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
+++ b/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
@@ -91,7 +91,7 @@ typedef struct {
1, /* AssociativityValid */ \
1, /* AllocationTypeValid */ \
1, /* CacheTypeValid */ \
- 0, /* WritePolicyValid */ \
+ 1, /* WritePolicyValid */ \
1, /* LineSizeValid */ \
}, \
0, /* NextLevelOfCache */ \
--
2.41.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111270): https://edk2.groups.io/g/devel/message/111270
Mute This Topic: https://groups.io/mt/102603819/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types
2023-11-15 12:46 [edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types Marcin Juszkiewicz
@ 2023-11-15 13:05 ` Leif Lindholm
2023-11-22 15:14 ` Leif Lindholm
1 sibling, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2023-11-15 13:05 UTC (permalink / raw)
To: Marcin Juszkiewicz
Cc: devel, Ard Biesheuvel, Graeme Gregory, Jeremy Linton, Ling Jia,
Marcin Wojtas, Peng Xie, Yiqi Shu
On Wed, Nov 15, 2023 at 13:46:08 +0100, Marcin Juszkiewicz wrote:
> acpiview complains:
>
> ERROR: On Arm based systems, all cache properties must be provided in
> the cache type structure. Missing 'Write Policy Valid' flag.
>
> ACPI specification says:
>
> > Set to 1 if the write policy attribute described is valid. A value
> > of 0 indicates that, where possible, processor architecture specific
> > discovery mechanisms should be used to ascertain the value of this
> > attribute.
Thanks for finding this. This is definitely an error (and I expect
this is a single original error that has then been copied around to
other platforms, so important to fix all of them).
But I can see how that mistake was made. The ACPI specification makes
no reference to what write policy means for instruction caches
(i.e. nothing).
However, the ACPI specification *does* make it crystal clear that "On
Arm-based systems, all cache properties must be provided in the
table.". So indicating that one of the entries is invalid is
... invalid.
So apparently all Arm instruction caches are Write-back. Lol.
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
I'll leave this one for a day or so before merging to allow
reviewers/maintainers to see and respond.
Regards,
Leif
> ---
> Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 2 +-
> Platform/RaspberryPi/AcpiTables/Pptt.aslc | 2 +-
> Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc | 2 +-
> Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc | 2 +-
> Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc | 2 +-
> Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> index 983d17f6fa50..61d8bce8c959 100644
> --- a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> +++ b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> @@ -126,7 +126,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Platform/RaspberryPi/AcpiTables/Pptt.aslc b/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> index a52bc5a31adf..b80f5ff1e057 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> +++ b/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> @@ -114,7 +114,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc b/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> index e03bfcd6211d..f3a9b90fb564 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> @@ -94,7 +94,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> index f37c7511134d..3793cbbca0b5 100644
> --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> @@ -94,7 +94,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> index ae1a21df23b9..04652653563e 100644
> --- a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> +++ b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> @@ -92,7 +92,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> index e351d82b9763..f3e9149769ea 100644
> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> @@ -91,7 +91,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> --
> 2.41.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111273): https://edk2.groups.io/g/devel/message/111273
Mute This Topic: https://groups.io/mt/102603819/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types
2023-11-15 12:46 [edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types Marcin Juszkiewicz
2023-11-15 13:05 ` Leif Lindholm
@ 2023-11-22 15:14 ` Leif Lindholm
1 sibling, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2023-11-22 15:14 UTC (permalink / raw)
To: Marcin Juszkiewicz
Cc: devel, Ard Biesheuvel, Graeme Gregory, Jeremy Linton, Ling Jia,
Marcin Wojtas, Peng Xie, Yiqi Shu
On Wed, Nov 15, 2023 at 13:46:08 +0100, Marcin Juszkiewicz wrote:
> acpiview complains:
>
> ERROR: On Arm based systems, all cache properties must be provided in
> the cache type structure. Missing 'Write Policy Valid' flag.
>
> ACPI specification says:
>
> > Set to 1 if the write policy attribute described is valid. A value
> > of 0 indicates that, where possible, processor architecture specific
> > discovery mechanisms should be used to ascertain the value of this
> > attribute.
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as 10e2eb030de3.
Thanks!
> ---
> Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 2 +-
> Platform/RaspberryPi/AcpiTables/Pptt.aslc | 2 +-
> Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc | 2 +-
> Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc | 2 +-
> Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc | 2 +-
> Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> index 983d17f6fa50..61d8bce8c959 100644
> --- a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> +++ b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> @@ -126,7 +126,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Platform/RaspberryPi/AcpiTables/Pptt.aslc b/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> index a52bc5a31adf..b80f5ff1e057 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> +++ b/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> @@ -114,7 +114,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc b/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> index e03bfcd6211d..f3a9b90fb564 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> @@ -94,7 +94,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> index f37c7511134d..3793cbbca0b5 100644
> --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> @@ -94,7 +94,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> index ae1a21df23b9..04652653563e 100644
> --- a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> +++ b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> @@ -92,7 +92,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> index e351d82b9763..f3e9149769ea 100644
> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> @@ -91,7 +91,7 @@ typedef struct {
> 1, /* AssociativityValid */ \
> 1, /* AllocationTypeValid */ \
> 1, /* CacheTypeValid */ \
> - 0, /* WritePolicyValid */ \
> + 1, /* WritePolicyValid */ \
> 1, /* LineSizeValid */ \
> }, \
> 0, /* NextLevelOfCache */ \
> --
> 2.41.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111607): https://edk2.groups.io/g/devel/message/111607
Mute This Topic: https://groups.io/mt/102603819/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-22 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-15 12:46 [edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types Marcin Juszkiewicz
2023-11-15 13:05 ` Leif Lindholm
2023-11-22 15:14 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox