* [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type @ 2024-03-30 5:22 Abdul Lateef Attar via groups.io 2024-04-01 1:03 ` Chang, Abner via groups.io 2024-04-22 10:50 ` Abdul Lateef Attar via groups.io 0 siblings, 2 replies; 7+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-03-30 5:22 UTC (permalink / raw) To: devel Cc: Abdul Lateef Attar, Abner Chang, Michael D Kinney, Liming Gao, Zhiguang Liu Define IPMI interface type as per specification version 2.0, section C1-1.1. Cc: Abner Chang <abner.chang@amd.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> --- MdePkg/MdePkg.dec | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 0c18e1decd..396d960dca 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -9,7 +9,7 @@ # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP<BR> # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR> # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> +# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.<BR> # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -2401,6 +2401,15 @@ # @Prompt Time-out for a response, internal gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60000|UINT32|0x00000036 + ## Indicates IPMI Interface Type + # The IPMI specification defines the following interface types: (section C1-1.1) + # 0 - Unknown + # 1 - KCS : Keyboard Controller Style + # 2 - SMIC : Server Management Interface Chip + # 3 - BT : Block Transfer + # 4 - SSIF : SMBus System Interface + gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 + [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] ## GUID identifying the Rng algorithm implemented by CPU instruction. # @Prompt CPU Rng algorithm's GUID. -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117248): https://edk2.groups.io/g/devel/message/117248 Mute This Topic: https://groups.io/mt/105228733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type 2024-03-30 5:22 [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type Abdul Lateef Attar via groups.io @ 2024-04-01 1:03 ` Chang, Abner via groups.io 2024-04-22 10:50 ` Abdul Lateef Attar via groups.io 1 sibling, 0 replies; 7+ messages in thread From: Chang, Abner via groups.io @ 2024-04-01 1:03 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), devel Cc: Attar, AbdulLateef (Abdul Lateef), Michael D Kinney, Liming Gao, Zhiguang Liu [AMD Official Use Only - General] Acked-by: Abner Chang <abner.chang@amd.com> > -----Original Message----- > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > Sent: Saturday, March 30, 2024 1:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Chang, > Abner <Abner.Chang@amd.com>; Michael D Kinney > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > Zhiguang Liu <zhiguang.liu@intel.com> > Subject: [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface > type > > Define IPMI interface type as per specification version 2.0, > section C1-1.1. > > Cc: Abner Chang <abner.chang@amd.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > --- > MdePkg/MdePkg.dec | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 0c18e1decd..396d960dca 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -9,7 +9,7 @@ > # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP<BR> > # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights > reserved.<BR> > # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR> > -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> > +# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights > reserved.<BR> > # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -2401,6 +2401,15 @@ > # @Prompt Time-out for a response, internal > > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond| > 60000|UINT32|0x00000036 > > + ## Indicates IPMI Interface Type > + # The IPMI specification defines the following interface types: (section C1- > 1.1) > + # 0 - Unknown > + # 1 - KCS : Keyboard Controller Style > + # 2 - SMIC : Server Management Interface Chip > + # 3 - BT : Block Transfer > + # 4 - SSIF : SMBus System Interface > + gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 > + > [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > ## GUID identifying the Rng algorithm implemented by CPU instruction. > # @Prompt CPU Rng algorithm's GUID. > -- > 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117270): https://edk2.groups.io/g/devel/message/117270 Mute This Topic: https://groups.io/mt/105228733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type 2024-03-30 5:22 [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type Abdul Lateef Attar via groups.io 2024-04-01 1:03 ` Chang, Abner via groups.io @ 2024-04-22 10:50 ` Abdul Lateef Attar via groups.io 2024-04-22 20:17 ` Sean 1 sibling, 1 reply; 7+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-04-22 10:50 UTC (permalink / raw) To: devel, Liming Gao, Michael D Kinney, Zhiguang Liu; +Cc: Abner Chang Gentle reminder, review please. On 30-03-2024 10:52, Abdul Lateef Attar wrote: > Define IPMI interface type as per specification version 2.0, > section C1-1.1. > > Cc: Abner Chang <abner.chang@amd.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > --- > MdePkg/MdePkg.dec | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 0c18e1decd..396d960dca 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -9,7 +9,7 @@ > # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP<BR> > # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR> > # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR> > -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> > +# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.<BR> > # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -2401,6 +2401,15 @@ > # @Prompt Time-out for a response, internal > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60000|UINT32|0x00000036 > > + ## Indicates IPMI Interface Type > + # The IPMI specification defines the following interface types: (section C1-1.1) > + # 0 - Unknown > + # 1 - KCS : Keyboard Controller Style > + # 2 - SMIC : Server Management Interface Chip > + # 3 - BT : Block Transfer > + # 4 - SSIF : SMBus System Interface > + gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 > + > [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > ## GUID identifying the Rng algorithm implemented by CPU instruction. > # @Prompt CPU Rng algorithm's GUID. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118087): https://edk2.groups.io/g/devel/message/118087 Mute This Topic: https://groups.io/mt/105228733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type 2024-04-22 10:50 ` Abdul Lateef Attar via groups.io @ 2024-04-22 20:17 ` Sean 2024-04-23 1:51 ` Chang, Abner via groups.io 0 siblings, 1 reply; 7+ messages in thread From: Sean @ 2024-04-22 20:17 UTC (permalink / raw) To: devel, AbdulLateef.Attar, Liming Gao, Michael D Kinney, Zhiguang Liu Cc: Abner Chang, Chris Fernald [-- Attachment #1: Type: text/plain, Size: 3288 bytes --] This seems like a bad design to require the ipmi interface type at such a high level in the code tree. UEFI provides plenty protocol and library abstractions for IPMI so I would really prefer not to leak this type of information into a PCD defined in MdePkg. Happy to discuss IPMI support and I would really like to see edk2, edk2-platforms/Features/ManageabilityPkg at master · tianocore/edk2-platforms (github.com) <https://github.com/tianocore/edk2-platforms/tree/master/Features/ManageabilityPkg>, microsoft/mu_feature_ipmi: Project Mu - Feature Repo- Firmware support for IPMI (github.com) <https://github.com/microsoft/mu_feature_ipmi>, and commercial vendors find some sort of alignment going forward as no one wins with the mess that is in the industry now. Thanks Sean On 4/22/2024 3:50 AM, Abdul Lateef Attar via groups.io wrote: > Gentle reminder, review please. > > On 30-03-2024 10:52, Abdul Lateef Attar wrote: >> Define IPMI interface type as per specification version 2.0, >> section C1-1.1. >> >> Cc: Abner Chang <abner.chang@amd.com> >> Cc: Michael D Kinney <michael.d.kinney@intel.com> >> Cc: Liming Gao <gaoliming@byosoft.com.cn> >> Cc: Zhiguang Liu <zhiguang.liu@intel.com> >> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> >> --- >> MdePkg/MdePkg.dec | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec >> index 0c18e1decd..396d960dca 100644 >> --- a/MdePkg/MdePkg.dec >> +++ b/MdePkg/MdePkg.dec >> @@ -9,7 +9,7 @@ >> # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development >> LP<BR> >> # Copyright (c) 2022, Loongson Technology Corporation Limited. All >> rights reserved.<BR> >> # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR> >> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights >> reserved.<BR> >> +# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights >> reserved.<BR> >> # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR> >> # >> # SPDX-License-Identifier: BSD-2-Clause-Patent >> @@ -2401,6 +2401,15 @@ >> # @Prompt Time-out for a response, internal >> gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60000|UINT32|0x00000036 >> + ## Indicates IPMI Interface Type >> + # The IPMI specification defines the following interface types: >> (section C1-1.1) >> + # 0 - Unknown >> + # 1 - KCS : Keyboard Controller Style >> + # 2 - SMIC : Server Management Interface Chip >> + # 3 - BT : Block Transfer >> + # 4 - SSIF : SMBus System Interface >> + gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 >> + >> [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] >> ## GUID identifying the Rng algorithm implemented by CPU >> instruction. >> # @Prompt CPU Rng algorithm's GUID. > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118103): https://edk2.groups.io/g/devel/message/118103 Mute This Topic: https://groups.io/mt/105228733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 5644 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type 2024-04-22 20:17 ` Sean @ 2024-04-23 1:51 ` Chang, Abner via groups.io 2024-04-23 4:47 ` Abdul Lateef Attar via groups.io 0 siblings, 1 reply; 7+ messages in thread From: Chang, Abner via groups.io @ 2024-04-23 1:51 UTC (permalink / raw) To: Sean Brogan, devel, Attar, AbdulLateef (Abdul Lateef), Liming Gao, Michael D Kinney, Zhiguang Liu Cc: Chris Fernald [-- Attachment #1: Type: text/plain, Size: 4206 bytes --] [AMD Official Use Only - General] Hi Sean, I was struggling when introduce IPMI KCS base IO PCD in Mde, although it is a industry value but seems it is fine to have it in ManageabilityPkg. How do you think if we relocate those IPMI PCDs back to ManageabilityPkg? Thanks Abner From: Sean Brogan <spbrogan@outlook.com> Sent: Tuesday, April 23, 2024 4:18 AM To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Liming Gao <gaoliming@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com> Cc: Chang, Abner <Abner.Chang@amd.com>; Chris Fernald <chris.fernald@outlook.com> Subject: Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. This seems like a bad design to require the ipmi interface type at such a high level in the code tree. UEFI provides plenty protocol and library abstractions for IPMI so I would really prefer not to leak this type of information into a PCD defined in MdePkg. Happy to discuss IPMI support and I would really like to see edk2, edk2-platforms/Features/ManageabilityPkg at master · tianocore/edk2-platforms (github.com)<https://github.com/tianocore/edk2-platforms/tree/master/Features/ManageabilityPkg>, microsoft/mu_feature_ipmi: Project Mu - Feature Repo- Firmware support for IPMI (github.com)<https://github.com/microsoft/mu_feature_ipmi>, and commercial vendors find some sort of alignment going forward as no one wins with the mess that is in the industry now. Thanks Sean On 4/22/2024 3:50 AM, Abdul Lateef Attar via groups.io wrote: Gentle reminder, review please. On 30-03-2024 10:52, Abdul Lateef Attar wrote: Define IPMI interface type as per specification version 2.0, section C1-1.1. Cc: Abner Chang <abner.chang@amd.com><mailto:abner.chang@amd.com> Cc: Michael D Kinney <michael.d.kinney@intel.com><mailto:michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn><mailto:gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com><mailto:zhiguang.liu@intel.com> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com><mailto:AbdulLateef.Attar@amd.com> --- MdePkg/MdePkg.dec | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 0c18e1decd..396d960dca 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -9,7 +9,7 @@ # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP<BR> # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR> # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> +# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.<BR> # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -2401,6 +2401,15 @@ # @Prompt Time-out for a response, internal gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60000|UINT32|0x00000036 + ## Indicates IPMI Interface Type + # The IPMI specification defines the following interface types: (section C1-1.1) + # 0 - Unknown + # 1 - KCS : Keyboard Controller Style + # 2 - SMIC : Server Management Interface Chip + # 3 - BT : Block Transfer + # 4 - SSIF : SMBus System Interface + gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 + [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] ## GUID identifying the Rng algorithm implemented by CPU instruction. # @Prompt CPU Rng algorithm's GUID. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118106): https://edk2.groups.io/g/devel/message/118106 Mute This Topic: https://groups.io/mt/105228733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 8817 bytes --] ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type 2024-04-23 1:51 ` Chang, Abner via groups.io @ 2024-04-23 4:47 ` Abdul Lateef Attar via groups.io 2024-04-23 6:12 ` Sean 0 siblings, 1 reply; 7+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-04-23 4:47 UTC (permalink / raw) To: Chang, Abner, Sean Brogan, devel, Liming Gao, Michael D Kinney, Zhiguang Liu Cc: Chris Fernald [-- Attachment #1: Type: text/plain, Size: 5264 bytes --] [AMD Official Use Only - General] HI Abner, Moving the IPMI related PCD’s will cause additional package dependencies. Suppose if someone wants to implement SPMI table using DynamicTablesPkg (and using this PCD); then it will cause dependencies on ManageabilityPkg which is not accepted. Thanks AbduL From: Chang, Abner <Abner.Chang@amd.com> Sent: Tuesday, April 23, 2024 7:22 AM To: Sean Brogan <spbrogan@outlook.com>; devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Liming Gao <gaoliming@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com> Cc: Chris Fernald <chris.fernald@outlook.com> Subject: RE: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type [AMD Official Use Only - General] Hi Sean, I was struggling when introduce IPMI KCS base IO PCD in Mde, although it is a industry value but seems it is fine to have it in ManageabilityPkg. How do you think if we relocate those IPMI PCDs back to ManageabilityPkg? Thanks Abner From: Sean Brogan <spbrogan@outlook.com<mailto:spbrogan@outlook.com>> Sent: Tuesday, April 23, 2024 4:18 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Cc: Chang, Abner <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>>; Chris Fernald <chris.fernald@outlook.com<mailto:chris.fernald@outlook.com>> Subject: Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. This seems like a bad design to require the ipmi interface type at such a high level in the code tree. UEFI provides plenty protocol and library abstractions for IPMI so I would really prefer not to leak this type of information into a PCD defined in MdePkg. Happy to discuss IPMI support and I would really like to see edk2, edk2-platforms/Features/ManageabilityPkg at master · tianocore/edk2-platforms (github.com)<https://github.com/tianocore/edk2-platforms/tree/master/Features/ManageabilityPkg>, microsoft/mu_feature_ipmi: Project Mu - Feature Repo- Firmware support for IPMI (github.com)<https://github.com/microsoft/mu_feature_ipmi>, and commercial vendors find some sort of alignment going forward as no one wins with the mess that is in the industry now. Thanks Sean On 4/22/2024 3:50 AM, Abdul Lateef Attar via groups.io wrote: Gentle reminder, review please. On 30-03-2024 10:52, Abdul Lateef Attar wrote: Define IPMI interface type as per specification version 2.0, section C1-1.1. Cc: Abner Chang <abner.chang@amd.com><mailto:abner.chang@amd.com> Cc: Michael D Kinney <michael.d.kinney@intel.com><mailto:michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn><mailto:gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com><mailto:zhiguang.liu@intel.com> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com><mailto:AbdulLateef.Attar@amd.com> --- MdePkg/MdePkg.dec | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 0c18e1decd..396d960dca 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -9,7 +9,7 @@ # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP<BR> # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR> # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> +# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.<BR> # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -2401,6 +2401,15 @@ # @Prompt Time-out for a response, internal gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60000|UINT32|0x00000036 + ## Indicates IPMI Interface Type + # The IPMI specification defines the following interface types: (section C1-1.1) + # 0 - Unknown + # 1 - KCS : Keyboard Controller Style + # 2 - SMIC : Server Management Interface Chip + # 3 - BT : Block Transfer + # 4 - SSIF : SMBus System Interface + gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 + [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] ## GUID identifying the Rng algorithm implemented by CPU instruction. # @Prompt CPU Rng algorithm's GUID. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118121): https://edk2.groups.io/g/devel/message/118121 Mute This Topic: https://groups.io/mt/105228733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 10735 bytes --] ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type 2024-04-23 4:47 ` Abdul Lateef Attar via groups.io @ 2024-04-23 6:12 ` Sean 0 siblings, 0 replies; 7+ messages in thread From: Sean @ 2024-04-23 6:12 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), Chang, Abner, devel, Liming Gao, Michael D Kinney, Zhiguang Liu Cc: Chris Fernald [-- Attachment #1: Type: text/plain, Size: 6856 bytes --] Shoving everything into mdepkg to avoid a perceived dependency issue doesn't really solve the problem. If dynamictables pkg wants to be tied to an implementation of ipmi then you will have that dependency problem regardless. If dynamic tables really wants to be the producer of SPMI then it could query information from the protocol which would allow it to scale to the 3+ implementations of ipmi I mentioned earlier (assuming the protocol definition can be agreed upon and made common). Or manageability package could be producer of the table. Traditionally many of the ACPI tables have come from the realm of the platform because of the detailed information they require. I don't think dynamic tables package will be able to produce all tables without more complete abstractions and dependencies. So yes, until there is much better alignment in uefi for ipmi support, I would prefer the pcds and all implementation details be kept in or moved back to manageability pkg. Thanks Sean ________________________________ From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com> Sent: Monday, April 22, 2024 9:47:32 PM To: Chang, Abner <Abner.Chang@amd.com>; Sean Brogan <spbrogan@outlook.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Liming Gao <gaoliming@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com> Cc: Chris Fernald <chris.fernald@outlook.com> Subject: RE: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type [AMD Official Use Only - General] HI Abner, Moving the IPMI related PCD’s will cause additional package dependencies. Suppose if someone wants to implement SPMI table using DynamicTablesPkg (and using this PCD); then it will cause dependencies on ManageabilityPkg which is not accepted. Thanks AbduL From: Chang, Abner <Abner.Chang@amd.com> Sent: Tuesday, April 23, 2024 7:22 AM To: Sean Brogan <spbrogan@outlook.com>; devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Liming Gao <gaoliming@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com> Cc: Chris Fernald <chris.fernald@outlook.com> Subject: RE: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type [AMD Official Use Only - General] Hi Sean, I was struggling when introduce IPMI KCS base IO PCD in Mde, although it is a industry value but seems it is fine to have it in ManageabilityPkg. How do you think if we relocate those IPMI PCDs back to ManageabilityPkg? Thanks Abner From: Sean Brogan <spbrogan@outlook.com<mailto:spbrogan@outlook.com>> Sent: Tuesday, April 23, 2024 4:18 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Cc: Chang, Abner <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>>; Chris Fernald <chris.fernald@outlook.com<mailto:chris.fernald@outlook.com>> Subject: Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. This seems like a bad design to require the ipmi interface type at such a high level in the code tree. UEFI provides plenty protocol and library abstractions for IPMI so I would really prefer not to leak this type of information into a PCD defined in MdePkg. Happy to discuss IPMI support and I would really like to see edk2, edk2-platforms/Features/ManageabilityPkg at master · tianocore/edk2-platforms (github.com)<https://github.com/tianocore/edk2-platforms/tree/master/Features/ManageabilityPkg>, microsoft/mu_feature_ipmi: Project Mu - Feature Repo- Firmware support for IPMI (github.com)<https://github.com/microsoft/mu_feature_ipmi>, and commercial vendors find some sort of alignment going forward as no one wins with the mess that is in the industry now. Thanks Sean On 4/22/2024 3:50 AM, Abdul Lateef Attar via groups.io wrote: Gentle reminder, review please. On 30-03-2024 10:52, Abdul Lateef Attar wrote: Define IPMI interface type as per specification version 2.0, section C1-1.1. Cc: Abner Chang <abner.chang@amd.com><mailto:abner.chang@amd.com> Cc: Michael D Kinney <michael.d.kinney@intel.com><mailto:michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn><mailto:gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com><mailto:zhiguang.liu@intel.com> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com><mailto:AbdulLateef.Attar@amd.com> --- MdePkg/MdePkg.dec | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 0c18e1decd..396d960dca 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -9,7 +9,7 @@ # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP<BR> # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR> # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> +# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.<BR> # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -2401,6 +2401,15 @@ # @Prompt Time-out for a response, internal gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60000|UINT32|0x00000036 + ## Indicates IPMI Interface Type + # The IPMI specification defines the following interface types: (section C1-1.1) + # 0 - Unknown + # 1 - KCS : Keyboard Controller Style + # 2 - SMIC : Server Management Interface Chip + # 3 - BT : Block Transfer + # 4 - SSIF : SMBus System Interface + gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 + [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] ## GUID identifying the Rng algorithm implemented by CPU instruction. # @Prompt CPU Rng algorithm's GUID. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118125): https://edk2.groups.io/g/devel/message/118125 Mute This Topic: https://groups.io/mt/105228733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 11897 bytes --] ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-04-23 6:12 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-03-30 5:22 [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type Abdul Lateef Attar via groups.io 2024-04-01 1:03 ` Chang, Abner via groups.io 2024-04-22 10:50 ` Abdul Lateef Attar via groups.io 2024-04-22 20:17 ` Sean 2024-04-23 1:51 ` Chang, Abner via groups.io 2024-04-23 4:47 ` Abdul Lateef Attar via groups.io 2024-04-23 6:12 ` Sean
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox